GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99180: Make `StackSummary.should_show_carets` private by AlexWaygood · Pull Request #119554 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See https://github.com/python/cpython/pull/112670/files#r1613952301. This wasn't meant to be a public API; prefixing the name with an underscore means it won't show up in help() or autocompletion suggestions.

  • Issue: Elide uninformative traceback indicators in return and simple assignment statements #99180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-99180: Make StackSummary.should_show_carets private
d612a34
@AlexWaygood
AlexWaygood requested a review from iritkatriel as a code owner May 25, 2024 16:47
@AlexWaygood AlexWaygood added the skip news label May 25, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2024
Elide uninformative traceback indicators in return and simple assignment statements #99180
Closed
@AlexWaygood
AlexWaygood requested a review from pablogsal May 25, 2024 16:47
@AlexWaygood AlexWaygood added the needs backport to 3.13 only security fixes label May 25, 2024
@AlexWaygood AlexWaygood mentioned this pull request May 25, 2024
gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range #112670
Merged
pablogsal
pablogsal approved these changes May 25, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 25, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 25, 2024 17:07
@AlexWaygood
AlexWaygood merged commit 4b7eb32 into python:main May 25, 2024
@AlexWaygood
AlexWaygood deleted the traceback-private branch May 25, 2024 17:08
@miss-islington-app

miss-islington-app Bot commented May 25, 2024

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2024
@AlexWaygood @miss-islington
pythongh-99180: Make StackSummary.should_show_carets private (pytho…
47494a2 
…nGH-119554)

(cherry picked from commit 4b7eb32)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented May 25, 2024

Copy link
Copy Markdown

GH-119556 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 25, 2024
AlexWaygood added a commit that referenced this pull request May 25, 2024
@miss-islington @AlexWaygood
[3.13] gh-99180: Make StackSummary.should_show_carets private (GH-1…
2404cd9 
…19554) (#119556)

Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@AlexWaygood @estyxx
pythongh-99180: Make StackSummary.should_show_carets private (pytho…
c0e9e0a 
…n#119554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.