GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115249: Fix `test_descr` with `-OO` mode by sobolevn · Pull Request #115250 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Now it passes with both -00 and without.

  • Issue: test_descr fails when run with -OO #115249

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-115249: Fix test_descr with -OO mode
acfad85
@sobolevn sobolevn added the skip news label Feb 10, 2024
@sobolevn
sobolevn requested a review from vstinner February 10, 2024 15:59
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2024
test_descr fails when run with -OO #115249
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 10, 2024
@terryjreedy

terryjreedy commented Feb 10, 2024 •
edited by Eclips4
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The Windows 86 free-threading failure in test_queue (timeout) is an independent failure reported in ##115258. Since the same passed on another of your PRs, I triggered a one-test rerun.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy
terryjreedy approved these changes Feb 10, 2024
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the proper fix for a buggy test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 10, 2024
@terryjreedy terryjreedy mentioned this pull request Feb 10, 2024
test_queue times out #115258
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Feb 10, 2024
View reviewed changes
@sobolevn sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 11, 2024
@sobolevn
sobolevn merged commit 1f23837 into python:main Feb 11, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2024
@sobolevn @miss-islington
pythongh-115249: Fix test_descr with -OO mode (pythonGH-115250)
842c8ed 
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

GH-115277 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2024
@sobolevn @miss-islington
pythongh-115249: Fix test_descr with -OO mode (pythonGH-115250)
13f6c40 
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 11, 2024
@bedevere-app

bedevere-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

GH-115278 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
sobolevn added a commit that referenced this pull request Feb 11, 2024
@miss-islington @sobolevn
[3.12] gh-115249: Fix test_descr with -OO mode (GH-115250) (#115277)
5baf90e 
gh-115249: Fix `test_descr` with `-OO` mode (GH-115250)
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit that referenced this pull request Feb 11, 2024
@miss-islington @sobolevn
[3.11] gh-115249: Fix test_descr with -OO mode (GH-115250) (#115278)
3aa9621 
gh-115249: Fix `test_descr` with `-OO` mode (GH-115250)
(cherry picked from commit 1f23837)

Co-authored-by: Nikita Sobolev <[email protected]>
@vstinner

vstinner commented Feb 12, 2024

Copy link
Copy Markdown
Member

Congrats @sobolevn for your first merge as a Python core dev! 🎉
sobolevn reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115249: Fix test_descr with -OO mode (python#115250)
ae6f000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@terryjreedy terryjreedy terryjreedy approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @terryjreedy @vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.