Description

Eclips4

opened on Feb 10, 2024

Issue body actions

Bug report

Bug description:

See https://github.com/python/cpython/actions/runs/7856342409/job/21439020143?pr=115257 for more details.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

• gh-115258: Temporarily disable test on Windows #115269
• gh-115258: Temporarily skip some queue tests on all platforms #115361
• gh-115258: Fix thread queue shutdown test #115898
• gh-115258: Fix failed tests on threading queue shutdown #115940

Reacted by pan324

Activity

1. Eclips4

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   OS-windows

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Feb 10, 2024
2. itamaro

   added

   topic-free-threading

   on Feb 10, 2024
3. terryjreedy commented on Feb 10, 2024

   

   terryjreedy

   on Feb 10, 2024

   Member

   More actions

   This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.
4. Eclips4

   changed the title [-]``test_queue`` timed out on Windows free-threading build (x86)[/-] [+]``test_queue`` timed out on Windows free-threading build[/+] on Feb 10, 2024
5. Eclips4 commented on Feb 10, 2024

   

   Eclips4

   on Feb 10, 2024

   MemberAuthor

   More actions

   This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.

   Also seems this issue is not specific to x86, another one fail on x64: #115232
6. Eclips4 commented on Feb 10, 2024

   

   Eclips4

   on Feb 10, 2024

   MemberAuthor

   More actions

   Looks related to #104750
7. terryjreedy commented on Feb 10, 2024

   

   terryjreedy

   on Feb 10, 2024

   Member

   More actions

   Since our workflow does not allow over-riding CI failure from unrelated test failures, I think test_queue.PyPriorityQueueTest.test_shutdown_all_methods_in_many_threads should be skipped until fixed.
8. gvanrossum commented on Feb 10, 2024

   

   gvanrossum

   on Feb 10, 2024

   Member

   More actions

   Shall we just revert gh-104750? It seems I merged it prematurely, see #104750 (comment).
9. gvanrossum

   added a commit that references this issue on Feb 10, 2024

   Revert "pythongh-96471: Add shutdown() method to queue.Queue (python#…

   b431b87
10. gvanrossum commented on Feb 10, 2024

    

    gvanrossum

    on Feb 10, 2024

    Member

    More actions

    If you want to just revert the offending PR, gh-115265 is a full revert (it's currently marinating in CI).

    If someone wants to volunteer to create an alternative PR that just disables that test (ideally only when Windows and free-threading are detected) that would be even better.
11. colesbury

    added 2 commits that reference this issue on Feb 11, 2024

    pythongh-115258: Temporarily disable test on free-threaded Windows build

    6eff26b

    pythongh-115258: Temporarily disable test on free-threaded Windows build

    807dfd4
12. colesbury

    self-assigned this

    on Feb 11, 2024
13. 15 remaining items
14. Eclips4

    added a commit that references this issue on Feb 12, 2024

    pythongh-115258: Temporarily skip test on all platforms

    7969043
15. Eclips4 commented on Feb 12, 2024

    

    Eclips4

    on Feb 12, 2024

    MemberAuthor

    More actions

    Okay, just disable those two tests for all platforms. (I'm not in a position to do it myself right now.)

    Done in #115361
16. colesbury

    added a commit that references this issue on Feb 12, 2024

    gh-115258: Temporarily skip some `queue` tests on all platforms (#115361

    bee2a11
17. fsc-eriker

    added 2 commits that reference this issue on Feb 14, 2024

    pythongh-115258: Temporarily disable test on Windows (python#115269)

    1f216d5

    pythongh-115258: Temporarily skip some `queue` tests on all platforms (…

    b3aa546
18. EpicWink

    added 2 commits that reference this issue on Feb 20, 2024

    WIP: fix threading queue shutdown all-methods-many-threads test (pyth…

    71da36a

    WIP: fix threading queue shutdown all-methods-many-threads test (pyth…

    57a8095
19. vstinner commented on Mar 14, 2024

    

    vstinner

    on Mar 14, 2024

    Member

    More actions

    What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.
20. gvanrossum commented on Mar 14, 2024

    

    gvanrossum

    on Mar 14, 2024

    Member

    More actions

    What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.

    Funny you should ask. There is a fix by the original authors (gh-115940), it just requires review and some validation. I don't want to rush things. Could you maybe review that PR?
21. gvanrossum

    added a commit that references this issue on Mar 18, 2024

    gh-115258: Fix hanging tests for threading queue shutdown (#115940)

    7707b14
22. gvanrossum commented on Mar 18, 2024

    

    gvanrossum

    on Mar 18, 2024

    Member

    More actions

    The updated tests have been pushed.

    Reacted by Victor Stinner
23. gvanrossum

    closed this as completedon Mar 18, 2024
24. vstinner

    added a commit that references this issue on Mar 20, 2024

    pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…

    8e779c3
25. adorilson

    added a commit that references this issue on Mar 25, 2024

    pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…

    3cbcb98
26. diegorusso

    added a commit that references this issue on Apr 17, 2024

    pythongh-115258: Fix hanging tests for threading queue shutdown (pyth…

    b577a43

Issue actions