GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115252: Fix `test_enum` with `-OO` mode by sobolevn · Pull Request #115253 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Now it passes with both modes.

  • Issue: test_enum fails when run with -OO #115252

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-115252: Fix test_enum with -00 mode
0f337e6
@sobolevn
sobolevn requested a review from ethanfurman as a code owner February 10, 2024 16:46
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2024
test_enum fails when run with -OO #115252
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 10, 2024
@sobolevn sobolevn added the skip news label Feb 10, 2024
ethanfurman
ethanfurman approved these changes Feb 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 10, 2024
@ethanfurman
ethanfurman merged commit 33f56b7 into python:main Feb 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 10, 2024
@ethanfurman ethanfurman changed the title gh-115252: Fix test_enum with -00 mode gh-115252: Fix test_enum with -OO mode Feb 10, 2024
@terryjreedy terryjreedy mentioned this pull request Feb 10, 2024
test_queue times out #115258
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 10, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 10, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Feb 10, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Feb 10, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33f56b743285f8419e92cfabe673fa165165a580 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned ethanfurman Feb 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2024
@sobolevn @miss-islington
pythongh-115252: Fix test_enum with -OO mode (pythonGH-115253)
c780fc8 
(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 10, 2024

Copy link
Copy Markdown

GH-115260 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 10, 2024
ethanfurman pushed a commit that referenced this pull request Feb 11, 2024
@miss-islington @sobolevn
[3.12] gh-115252: Fix test_enum with -OO mode (GH-115253) (GH-115260
ada6629 
)

(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 11, 2024
@sobolevn
[3.11] pythongh-115252: Fix test_enum with -OO mode (pythonGH-115253
b02dbc0 
)
@bedevere-app

bedevere-app Bot commented Feb 11, 2024

Copy link
Copy Markdown

GH-115279 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
sobolevn added a commit that referenced this pull request Feb 11, 2024
@sobolevn
[3.11] gh-115252: Fix test_enum with -OO mode (GH-115253) (#115279)
879d8c4 
(cherry picked from commit 33f56b7)

Co-authored-by: Nikita Sobolev <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115252: Fix test_enum with -OO mode (pythonGH-115253)
1b11ee4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @ethanfurman @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.