GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)" by gvanrossum · Pull Request #115265 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 10, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reason for the revert: #115258 test_queue timed out on Windows free-threading build.

The PR author had mentioned this in
#104750 (comment) but I forgot about it and merged anyway.

This reverts commit b2d9d13.

  • Issue: Queue shutdown #96471

📚 Documentation preview 📚: https://cpython-previews--115265.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Revert "pythongh-96471: Add shutdown() method to queue.Queue (python#…
b431b87 
…104750)"

Reason for the revert: python#115258
test_queue timed out on Windows free-threading build.

The PR author had mentioned this in
python#104750 (comment)
but I forgot about it and merged anyway.

This reverts commit b2d9d13.
@gvanrossum
gvanrossum requested a review from rhettinger as a code owner February 10, 2024 23:13
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 10, 2024
Queue shutdown #96471
Open
@gvanrossum

gvanrossum commented Feb 10, 2024

Copy link
Copy Markdown
Member Author

@EpicWink Just letting you know your PR might be reverted. Don't worry, we can resubmit we disable the offending test. We may also be able to avoid reverting the whole PR by just disabling that test, if we're convinced the problem is restricted to the combination of free-threading, Windows, and that specific test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum mentioned this pull request Feb 10, 2024
test_queue times out #115258
Closed
@terryjreedy

terryjreedy commented Feb 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

After reviewing the added code, I suggest immediately reverting the failing test on Windows free-thread builds to stop interfering with good PRs, and monitor for other CI/buildbot failures, while investigating. I was thinking about debug prints but then saw the note on the original PR that they themselves cause failures.

EDIT: side note line 241: n_items is not used in this function as _qsize is re-called each loop.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Closing in favor of #115269 which disables the offending tests on Windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum closed this Feb 11, 2024
@gvanrossum
gvanrossum deleted the revert-gh-104750 branch February 17, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gvanrossum @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.