GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115258: Temporarily disable test on Windows by colesbury · Pull Request #115269 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI. This skips the test on that platform until we figure out the root cause.

  • Issue: test_queue times out #115258

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 and EpicWink reacted with thumbs up emoji stonebig reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction
@colesbury
pythongh-115258: Temporarily disable test on free-threaded Windows build
807dfd4 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows
free-threaded CI. This skips the test on that platform and configuration until
we figure out the root cause.
@colesbury
colesbury requested review from Eclips4, gvanrossum and terryjreedy February 11, 2024 02:11
@colesbury
colesbury requested a review from rhettinger as a code owner February 11, 2024 02:11
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 11, 2024
@colesbury colesbury added skip news and removed awaiting core review labels Feb 11, 2024
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 11, 2024
test_queue times out #115258
Closed
@colesbury
Skip another test
9ba3d90
gvanrossum
gvanrossum approved these changes Feb 11, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are you comfortable merging this yourself?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added the awaiting merge label Feb 11, 2024
@colesbury

colesbury commented Feb 11, 2024

Copy link
Copy Markdown
Contributor Author

I'll update the tests to just skip on Windows
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury added 2 commits February 10, 2024 21:55
@colesbury
Skip test on Windows (not just free-threaded build)
09bd7cb
@colesbury
Use consistent quote style
48356a8
@colesbury
colesbury enabled auto-merge (squash) February 11, 2024 02:58
@colesbury colesbury changed the title gh-115258: Temporarily disable test on Windows free-threaded build gh-115258: Temporarily disable test on Windows Feb 11, 2024
@colesbury
colesbury merged commit 1a6e213 into python:main Feb 11, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 11, 2024
@colesbury
colesbury deleted the gh-115258-skip branch February 11, 2024 03:26
@gvanrossum gvanrossum mentioned this pull request Feb 11, 2024
Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)" #115265
Closed
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@colesbury @fsc-eriker
pythongh-115258: Temporarily disable test on Windows (python#115269)
1f216d5 
The "test_shutdown_all_methods_in_many_threads" test times out on the Windows CI.
This skips the test on Windows until we figure out the root cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@Eclips4 Eclips4 Awaiting requested review from Eclips4
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.