GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116417: Avoid PyFloat_AS_DOUBLE() in AC limited C API by vstinner · Pull Request #116568 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of the limited C API is requested.

  • Issue: C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-116417: Avoid PyFloat_AS_DOUBLE() in AC limited C API
d3b6276 
Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
@vstinner
vstinner requested a review from erlend-aasland as a code owner March 10, 2024 17:14
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2024
C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417
Closed
@vstinner

vstinner commented Mar 10, 2024

Copy link
Copy Markdown
Member Author

cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Mar 10, 2024
@vstinner
vstinner merged commit 729bfb3 into python:main Mar 10, 2024
@vstinner
vstinner deleted the ac_float branch March 10, 2024 19:42
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 10, 2024
@erlend-aasland

erlend-aasland commented Mar 10, 2024

Copy link
Copy Markdown
Contributor

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Mar 10, 2024
gh-116417: Argument Clinic: test generated Limited C API code for float args #116573
Merged
@vstinner

vstinner commented Mar 11, 2024

Copy link
Copy Markdown
Member Author

I'm working on a large refactoring of C API tests and I need to merge multiple small changes in a row. Thanks for the follow-up, I'm not used to AC tests. First I even wanted to avoid tests, but then I recall limited C API tests for AC. At least, check that generated C code compiles properly.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@vstinner @adorilson
pythongh-116417: Avoid PyFloat_AS_DOUBLE() in AC limited C API (pytho…
b5092a2 
…n#116568)

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-116417: Avoid PyFloat_AS_DOUBLE() in AC limited C API (pytho…
7a97ca7 
…n#116568)

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.