GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116417: Argument Clinic: test generated Limited C API code for float args by erlend-aasland · Pull Request #116573 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-116417: Argument Clinic: test generated Limited C API code f…
e03947b 
…or float args
@erlend-aasland erlend-aasland added the skip news label Mar 10, 2024
@erlend-aasland
erlend-aasland requested a review from vstinner March 10, 2024 21:40
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2024
C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 10, 2024
@erlend-aasland

erlend-aasland commented Mar 10, 2024

Copy link
Copy Markdown
Contributor Author

Follow-up of #116568
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Mar 11, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 11, 2024
@erlend-aasland
erlend-aasland merged commit 8d7fde6 into python:main Mar 11, 2024
@erlend-aasland
erlend-aasland deleted the clinic/test-limited-capi-float branch March 11, 2024 07:44
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 11, 2024
@erlend-aasland

erlend-aasland commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@erlend-aasland @adorilson
pythongh-116417: Argument Clinic: test generated Limited C API code f…
493b403 
…or float args (python#116573)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-116417: Argument Clinic: test generated Limited C API code f…
1c4c950 
…or float args (python#116573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.