GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117953: Share More Machinery Code Between Builtin and Dynamic Extensions by ericsnowcurrently · Pull Request #118204 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've pulled this out of gh-118116.

This change will make some later changes simpler. It also brings more consistent behavior and lower maintenance costs.

  • Issue: Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Apr 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 24, 2024
Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953
Closed
@ericsnowcurrently
ericsnowcurrently force-pushed the builtins-and-extensions-shared-code branch from 32a319a to 6f7a862 Compare April 24, 2024 21:30
ericsnowcurrently added 5 commits April 29, 2024 09:30
@ericsnowcurrently
Use _PyImport_RunModInitFunc() in create_builtin().
b88c403
@ericsnowcurrently
Allow mod->md_def to be NULL.
21d259e
@ericsnowcurrently
Call _PyImport_RunModInitFunc() in reload_singlephase_extension().
5756201
@ericsnowcurrently
Factor out import_run_extension().
b932173
@ericsnowcurrently
Update the comment about extensions.
c897f6a
@ericsnowcurrently
ericsnowcurrently force-pushed the builtins-and-extensions-shared-code branch from 9508b74 to c897f6a Compare April 29, 2024 15:32
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review April 29, 2024 15:37
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, kumaraditya303, ncoghlan and warsaw as code owners April 29, 2024 15:37
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 29, 2024
@ericsnowcurrently
ericsnowcurrently removed request for brettcannon, kumaraditya303, ncoghlan and warsaw April 29, 2024 15:37
@ericsnowcurrently
ericsnowcurrently merged commit 529a160 into python:main Apr 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 29, 2024
@ericsnowcurrently
ericsnowcurrently deleted the builtins-and-extensions-shared-code branch April 29, 2024 18:53
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 12, 2024
gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set #122952
Merged
ericsnowcurrently added a commit that referenced this pull request Aug 13, 2024
@ericsnowcurrently
gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)
ee1b8ce
As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2024
@ericsnowcurrently @miss-islington
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
70d359b
…h-122952)

As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
(cherry picked from commit ee1b8ce)

Co-authored-by: Eric Snow <[email protected]>
@miss-islington miss-islington mentioned this pull request Aug 13, 2024
[3.13] gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952) #122984
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@ericsnowcurrently @blhsing
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
8c46cb4
…h-122952)

As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
Yhg1s pushed a commit that referenced this pull request Dec 3, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952
dddea7c
) (#122984)

gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)

As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
(cherry picked from commit ee1b8ce)

Co-authored-by: Eric Snow <[email protected]>
@itamaro itamaro mentioned this pull request Oct 12, 2025
Inittab modules in packages hit an assertion since Python 3.13 #140011
Closed
@encukou encukou mentioned this pull request Nov 17, 2025
gh-140011: Delete importdl assertion that prevents importing embedded modules from packages #141605
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.