GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set by ericsnowcurrently · Pull Request #122952 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.

  • Issue: Compilation is broken with HAVE_DYNAMIC_LOADING=0 #122907

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits August 12, 2024 11:07
@ericsnowcurrently
Move #ifdef HAVE_DYNAMIC_LOADING to the right spots.
bcf4a16
@ericsnowcurrently
Fix check_extension_modules.py.
ba8d346
@ericsnowcurrently
Do not add ExtensionFileLoader if _imp.create_dynamic() is missing.
ef06148
@ericsnowcurrently
Add a NEWS entry.
ed51f4e
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.13 only security fixes label Aug 12, 2024
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, ncoghlan and warsaw as code owners August 12, 2024 17:45
@bedevere-app bedevere-app Bot mentioned this pull request Aug 12, 2024
Compilation is broken with HAVE_DYNAMIC_LOADING=0 #122907
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 12, 2024
brettcannon
brettcannon approved these changes Aug 13, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 13, 2024
@ericsnowcurrently
ericsnowcurrently merged commit ee1b8ce into python:main Aug 13, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 13, 2024

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 13, 2024
@ericsnowcurrently
ericsnowcurrently deleted the fix-HAVE_DYNAMIC_LOADING-basic branch August 13, 2024 20:45
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2024
@ericsnowcurrently @miss-islington
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
70d359b 
…h-122952)

As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
(cherry picked from commit ee1b8ce)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 13, 2024

Copy link
Copy Markdown

GH-122984 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 13, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@ericsnowcurrently @blhsing
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
8c46cb4 
…h-122952)

As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
Yhg1s pushed a commit that referenced this pull request Dec 3, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952
dddea7c 
) (#122984)

gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)

As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working.  This is a minimal fix just to get builds working again.  There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
(cherry picked from commit ee1b8ce)

Co-authored-by: Eric Snow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.