GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: Upgrade to Sphinx 7.3 by hugovk · Pull Request #118397 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Apr 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I also find Sphinx's short options rather cryptic (-q -n -W --keep-going -w), let's prefer the long options introduced in Sphinx 7.3: https://www.sphinx-doc.org/en/master/changes.html#release-7-3-0-released-apr-16-2024

We can't yet use long options for the "Docs (Oldest Sphinx)" CI build, which is testing Sphinx 6.2.1, or in the Makefile which it also uses.

📚 Documentation preview 📚: https://cpython-previews--118397.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits April 29, 2024 18:43
@hugovk
Upgrade to Sphinx 7.3
e3d4376
@hugovk
Use Sphinx 7.3's long options
4ec0ff6
@hugovk
hugovk requested a review from ezio-melotti as a code owner April 29, 2024 15:46
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 29, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes skip issue skip news and removed awaiting core review labels Apr 29, 2024
@hugovk
Keep Sphinx short options in Makefile
0a53345
ezio-melotti
ezio-melotti approved these changes Apr 29, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Apr 29, 2024
@hugovk
hugovk merged commit 8d4b756 into python:main Apr 29, 2024
@hugovk
hugovk deleted the docs-upgrade-sphinx branch April 29, 2024 17:40
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 29, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 29, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2024
@hugovk @miss-islington
Docs: Upgrade to Sphinx 7.3 (pythonGH-118397)
9e4e337 
(cherry picked from commit 8d4b756)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 29, 2024

Copy link
Copy Markdown

GH-118400 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 29, 2024
hugovk added a commit that referenced this pull request Apr 29, 2024
@miss-islington @hugovk
[3.12] Docs: Upgrade to Sphinx 7.3 (GH-118397) (#118400)
0a1bed1 
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Apr 29, 2024
Doc workflow is failing due to a missing file 'Doc/sphinx-warnings.txt' #118401
Closed
@AA-Turner AA-Turner mentioned this pull request Jan 20, 2025
GH-125722: Use long options for Sphinx #129039
Merged
@hugovk hugovk mentioned this pull request Oct 31, 2026
Docs: Upgrade Sphinx to 9.1 #159945
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.