GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125722: Use long options for Sphinx by AA-Turner · Pull Request #129039 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jan 20, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Sphinx 7.3 added long options to sphinx-build, which this PR proposes using.

Hugo added these in #118397, but had to revert them in #118401 (#118403). Nine months have passed and the median PR branch will probably have Sphinx 7.3, and if not we can use the "Update Branch" button, so I think we should try to use the long options again.

A

  • Issue: Use the latest Sphinx version #125722

📚 Documentation preview 📚: https://cpython-previews--129039.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Use long options for Sphinx
0a7d1c4
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jan 20, 2025
@AA-Turner
AA-Turner requested review from ezio-melotti and hugovk as code owners January 20, 2025 00:59
@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Use the latest Sphinx version #125722
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2025
ezio-melotti
ezio-melotti approved these changes Jan 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 20, 2025
hugovk
hugovk approved these changes Jan 20, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit 4967fa6 into python:main Jan 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@AA-Turner @miss-islington
pythonGH-125722: Use long options for Sphinx (pythonGH-129039)
092e201 
(cherry picked from commit 4967fa6)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@AA-Turner @miss-islington
pythonGH-125722: Use long options for Sphinx (pythonGH-129039)
dba31c9 
(cherry picked from commit 4967fa6)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129041 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 20, 2025
@bedevere-app

bedevere-app Bot commented Jan 20, 2025

Copy link
Copy Markdown

GH-129042 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 20, 2025
hugovk pushed a commit that referenced this pull request Jan 20, 2025
@miss-islington @AA-Turner
[3.13] GH-125722: Use long options for Sphinx (GH-129039) (#129041)
59b919b 
GH-125722: Use long options for Sphinx (GH-129039)
(cherry picked from commit 4967fa6)

Co-authored-by: Adam Turner <[email protected]>
hugovk pushed a commit that referenced this pull request Jan 20, 2025
@miss-islington @AA-Turner
[3.12] GH-125722: Use long options for Sphinx (GH-129039) (#129042)
49b2f31 
GH-125722: Use long options for Sphinx (GH-129039)
(cherry picked from commit 4967fa6)

Co-authored-by: Adam Turner <[email protected]>
@AA-Turner
AA-Turner deleted the docs/long-options branch January 20, 2025 12:40
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@AA-Turner @srinivasreddy
pythonGH-125722: Use long options for Sphinx (python#129039)
6d6cf36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @hugovk @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.