GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (GH-119065) by serhiy-storchaka · Pull Request #119088 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 0152dc4)

  • Issue: Test with the path protocol, not with pathlib.Path #119064

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka requested review from a team, 1st1, asvetlov, ethanfurman, gpshead, gvanrossum, jaraco, kumaraditya303, vsajip and willingc as code owners May 16, 2024 07:33
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 16, 2024
This was referenced May 16, 2024
Test with the path protocol, not with pathlib.Path #119064
Closed
gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests #119065
Merged
@bedevere-app bedevere-app Bot added the skip news label May 16, 2024
@serhiy-storchaka
[3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
fb1870a 
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka force-pushed the backport-0152dc4-3.12 branch from b4b2738 to fb1870a Compare May 16, 2024 07:48
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 16, 2024 07:51
@serhiy-storchaka
serhiy-storchaka merged commit 33a9f0c into python:3.12 May 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 16, 2024
@serhiy-storchaka
serhiy-storchaka deleted the backport-0152dc4-3.12 branch October 21, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.