Description

serhiy-storchaka

opened on May 15, 2024

Issue body actions

A number of tests use pathlib.Path to test that the code supports path-like objects. They should use a special object that only implements the path protocol instead. This will avoid unintentional dependency on other pathlib.Path methods and attributes and allow to test path-like objects with the bytes path.

Linked PRs

• gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests #119065
• [3.13] gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (GH-119065) #119087
• [3.12] gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (GH-119065) #119088
• [3.11] gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (GH-119065) #119089

Reacted by Alex Waygood and Barney Gale

Activity

1. serhiy-storchaka

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   3.12only security fixesonly security fixes

   3.13only security fixesonly security fixes

   3.14bugs and security fixesbugs and security fixes

   on May 15, 2024
2. serhiy-storchaka

   added 4 commits that reference this issue on May 15, 2024

   pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in tests

   e5c9233

   pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in tests

   aded70a

   pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in tests

   20e44cd

   gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (G…

   0152dc4
3. miss-islington

   added a commit that references this issue on May 16, 2024

   pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in te…

   c4c1b04
4. serhiy-storchaka

   added 4 commits that reference this issue on May 16, 2024

   [3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…

   b4b2738

   [3.11] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…

   b1d7360

   [3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…

   fb1870a

   [3.13] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…

   1dc7fcd
5. serhiy-storchaka

   closed this as completedon May 16, 2024
6. serhiy-storchaka

   added a commit that references this issue on May 16, 2024

   [3.12] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…

   33a9f0c
7. estyxx

   added a commit that references this issue on Jul 17, 2024

   pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in te…

   5dafb14

Issue actions