GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests by serhiy-storchaka · Pull Request #119065 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Test with the path protocol, not with pathlib.Path #119064

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 15, 2024
@serhiy-storchaka
serhiy-storchaka requested review from a team, 1st1, asvetlov, ericsnowcurrently, ethanfurman, gpshead, gvanrossum, jaraco, kumaraditya303, vsajip and willingc as code owners May 15, 2024 08:54
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 15, 2024
Test with the path protocol, not with pathlib.Path #119064
Closed
@serhiy-storchaka
serhiy-storchaka force-pushed the test-path-like branch from e5c9233 to aded70a Compare May 15, 2024 08:56
@serhiy-storchaka
pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in tests
20e44cd
@serhiy-storchaka
serhiy-storchaka force-pushed the test-path-like branch from aded70a to 20e44cd Compare May 15, 2024 09:26
hauntsaninja
hauntsaninja approved these changes May 16, 2024
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/test/test_tarfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 16, 2024
serhiy-storchaka
serhiy-storchaka commented May 16, 2024
View reviewed changes
Comment thread Lib/test/test_tarfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_tarfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
Update Lib/test/test_tarfile.py
1390ba8
@serhiy-storchaka
serhiy-storchaka merged commit 0152dc4 into python:main May 16, 2024
@miss-islington-app

miss-islington-app Bot commented May 16, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label May 16, 2024
@serhiy-storchaka
serhiy-storchaka deleted the test-path-like branch May 16, 2024 07:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka @miss-islington
pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in te…
c4c1b04
…sts (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington-app

miss-islington-app Bot commented May 16, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0152dc4ff5534fa2948b95262e70ff6b202b9b99 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka May 16, 2024
@bedevere-app

bedevere-app Bot commented May 16, 2024

Copy link
Copy Markdown

GH-119087 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 16, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
b4b2738
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 16, 2024

Copy link
Copy Markdown

GH-119088 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 16, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.11] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
b1d7360
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 16, 2024

Copy link
Copy Markdown

GH-119089 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
fb1870a
…h in tests (pythonGH-119065)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 16, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…
1dc7fcd
…ests (GH-119065) (GH-119087)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@jaraco

jaraco commented May 16, 2024

Copy link
Copy Markdown
Member

These changes will need to be backported to zipp as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jaraco jaraco mentioned this pull request May 16, 2024
Backport changes from python/cpython#119065 jaraco/zipp#116
Closed
@jaraco

jaraco commented May 16, 2024

Copy link
Copy Markdown
Member

Also configparser.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jaraco jaraco mentioned this pull request May 16, 2024
Backport changes from python/cpython#119065 jaraco/configparser#72
Closed
@jaraco

jaraco commented May 16, 2024

Copy link
Copy Markdown
Member

And backports.tarfile.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jaraco jaraco mentioned this pull request May 16, 2024
Backport changes from python/cpython#119065 #119090
Closed
serhiy-storchaka added a commit that referenced this pull request May 16, 2024
@serhiy-storchaka
[3.12] gh-119064: Use os_helper.FakePath instead of pathlib.Path in t…
33a9f0c
…ests (GH-119065) (GH-119088)

(cherry picked from commit 0152dc4)
jaraco pushed a commit to jaraco/zipp that referenced this pull request May 16, 2024
@serhiy-storchaka @jaraco
gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (p…
cdbd58b
…ython/cpython#119065)

Closes #116.
@jaraco jaraco mentioned this pull request May 16, 2024
Backport changes from python/cpython#119065 jaraco/backports.tarfile#8
Closed
clrpackages pushed a commit to clearlinux-pkgs/pypi-zipp that referenced this pull request May 17, 2024
@fenrus75
pypi-zipp: Autospec creation for update from version 3.18.1 to versio…
c1306f5
…n 3.18.2

Avasam (1):
      Allow mypy on PyPy (jaraco/skeleton#111)

Bartosz Sławecki (2):
      Add link to blog entry from jaraco/skeleton#115 above CI build matrix.
      Move project metadata to `pyproject.toml` (jaraco/skeleton#122)

Jason R. Coombs (13):
      Update compatibility matrix to reflect changes merged in Python 3.12 and anticipated for 3.13.
      Re-enable ignoring of temporary merge queue branches. Closes jaraco/skeleton#103.
      Fetch unshallow clones in readthedocs. Closes jaraco/skeleton#114.
      Move Python 3.11 out of the test matrix.
      Configure pytest to support namespace packages. Ref pytest-dev/pytest#12112.
      Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
      Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Utilize temp_dir from os_helper.
      Use an overlay object to make tests appear to use zipfile.Path to reduce diff with CPython.
      Finalize

Serhiy Storchaka (1):
      gh-119064: Use os_helper.FakePath instead of pathlib.Path in tests (python/cpython#119065)

Xie Yanbo (1):
      Fix typo in Lib/zipfile/_path/__init__.py
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-119064: Use os_helper.FakePath instead of pathlib.Path in te…
5dafb14
…sts (pythonGH-119065)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @jaraco @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.