GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-69214: Fix fcntl.ioctl() request type (#119498) by vstinner · Pull Request #119505 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

(cherry picked from commit 92fab33)

  • Issue: Fix fcntl module to accept 'unsigned long' type commands for ioctl(2). #69214

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-69214: Fix fcntl.ioctl() request type (python#119498)
729941c
Use an 'unsigned long' instead of an 'unsigned int' for the request
parameter of fcntl.ioctl() to support requests larger than UINT_MAX.

(cherry picked from commit 92fab33)
@bedevere-app bedevere-app Bot added the awaiting core review label May 24, 2024
This was referenced May 24, 2024
Fix fcntl module to accept 'unsigned long' type commands for ioctl(2). #69214
Closed
gh-69214: Fix fcntl.ioctl() request type #119498
Merged
@vstinner
vstinner enabled auto-merge (squash) May 24, 2024 12:35
@vstinner
vstinner merged commit 078da88 into python:3.12 May 24, 2024
@vstinner
vstinner deleted the ioctl_long312 branch May 24, 2024 12:53
@bedevere-app bedevere-app Bot removed the awaiting core review label May 24, 2024
@Eclips4 Eclips4 mentioned this pull request May 31, 2024
gh-119770: Make termios ioctl() constants positive #119840
Merged
@bedevere-app

bedevere-app Bot commented Jun 1, 2024

Copy link
Copy Markdown

GH-119905 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (python…
965b4b7
…#119498) (python#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
vstinner added a commit that referenced this pull request Jun 1, 2024
@vstinner
[3.12] Revert "[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498…
34a0e7a
…) (#1… (#119905)

Revert "[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498) (#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.