GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119770: Make termios ioctl() constants positive by vstinner · Pull Request #119840 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 31, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_ioctl fails on macOS #119770

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting core review label May 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
test_ioctl fails on macOS #119770
Closed
@vstinner
vstinner force-pushed the termios_positive branch 2 times, most recently from 8dd2f14 to 9db77ce Compare May 31, 2024 11:04
@vstinner
pythongh-119770: Make termios ioctl() constants positive
e586f65
@vstinner
vstinner force-pushed the termios_positive branch from 9db77ce to e586f65 Compare May 31, 2024 11:06
@vstinner vstinner mentioned this pull request May 31, 2024
gh-119770: Remove buggy ioctl test case #119818
Closed
@vstinner

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

@Eclips4 or @sobolevn: Would you mind to try this fix on macOS?
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 Eclips4 self-assigned this May 31, 2024
Eclips4
Eclips4 approved these changes May 31, 2024
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it locally and everything worked as expected. Thank you Victor!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 31, 2024
@vstinner
vstinner merged commit 64ff1e2 into python:main May 31, 2024
@vstinner
vstinner deleted the termios_positive branch May 31, 2024 15:18
@miss-islington-app

miss-islington-app Bot commented May 31, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@vstinner @miss-islington
pythongh-119770: Make termios ioctl() constants positive (pythonGH-11…
a612c80 
…9840)

(cherry picked from commit 64ff1e2)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@vstinner @miss-islington
pythongh-119770: Make termios ioctl() constants positive (pythonGH-11…
3286fcd 
…9840)

(cherry picked from commit 64ff1e2)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented May 31, 2024

Copy link
Copy Markdown

GH-119862 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 31, 2024
@vstinner vstinner removed the needs backport to 3.12 only security fixes label May 31, 2024
@bedevere-app

bedevere-app Bot commented May 31, 2024

Copy link
Copy Markdown

GH-119863 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 31, 2024

Copy link
Copy Markdown
Member Author

@Eclips4 added needs backport to 3.12 needs backport to 3.13 labels

Oh no, I disagree. That's a backward incompatible change. I don't think that we should backport it. It's not a bugfix. In Python 3.13, "it just works".

This change was needed because I changed ioctl() request parameter type from C unsigned int to C unsigned long in Python 3.14.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented May 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This change was needed because I changed ioctl() request parameter type from C unsigned int to C unsigned long in Python 3.14.

But this change was backported to versions 3.12 and 3.13, so shouldn't it also be backported since it fixes at least one failing test?
#119504
#119505
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented May 31, 2024

Copy link
Copy Markdown
Member

Or another option: reverting this change for 3.12 && 3.13 branches since this break backwards compatibility
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

Or another option: reverting this change for 3.12 && 3.13 branches since this break backwards compatibility

Right, I created two revert changes:

  • [3.12] Revert "[3.12] gh-69214: Fix fcntl.ioctl() request type (#119498) (#1… #119905
  • [3.13] Revert "[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-119498) (… #119906
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119770: Make termios ioctl() constants positive (python#119840)
8f4af9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Eclips4 Eclips4

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.