GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups by andrewnester · Pull Request #120 · python/cpython

Conversation

@andrewnester

@andrewnester andrewnester commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

Fix for https://bugs.python.org/issue29553
Alternative to #117
This alternative advised by Christoph Stahl and Brian Curtin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2017
@andrewnester andrewnester changed the title bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups Feb 15, 2017
berkerpeksag
berkerpeksag requested changes Feb 19, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #117 (comment) about tests I left in #117.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewnester

andrewnester commented Feb 19, 2017

Copy link
Copy Markdown
Contributor Author

@berkerpeksag thanks! just updated my PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andrewnester added 2 commits February 22, 2017 16:38
@andrewnester
bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive …
62877a3 
…groups
@andrewnester
Update tests for ArgumentParser
87b9ec8
zhangyangyu
zhangyangyu reviewed Feb 22, 2017
View reviewed changes
Comment thread Misc/NEWS Outdated

@zhangyangyu zhangyangyu Feb 22, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an empty line here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@andrewnester andrewnester Feb 22, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangyangyu updated, sorry! thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andrewnester added 2 commits February 22, 2017 16:57
@andrewnester
Updated MISC/NEWS
b967369
@andrewnester
Increased test coverage for argparse
3f0ea54
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.4-slp (Stackless python#120)
f568fd7
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#120: Correctly grab the head_mutex
66f017b 
Stackless now correctly grabs and releases the head_mutex, if it
iterates over the linked list of Py_ThreadState structures.

https://bitbucket.org/stackless-dev/stackless/issues/120
(grafted from 1fb75d58a98083b2547746adb21fa238bbf8135a)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.3-slp (Stackless python#120)
b531101
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#120: Correctly grab the head_mutex, fix grafting error
ae1d0a4 
This commit fixes a regression introduced by commit fc13eecdd0ad.
When I grafted the patch for this issue from branch 2.7-slp (1fb75d58a), I forgot to remove a 2.7-slp only part of the code.
In effect, this change reapplies commit b8a8122bbb91.

https://bitbucket.org/stackless-dev/stackless/issues/120
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.3-slp (Stackless python#120, fix grafting error)
5b2c817
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.4-slp (Stackless python#120, fix grafting error)
f2db876
@Mariatta Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017
@brettcannon

brettcannon commented Feb 21, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added the awaiting changes label Feb 21, 2018
@berkerpeksag

berkerpeksag commented Aug 31, 2019

Copy link
Copy Markdown
Member

Superseded by PR #14976.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag closed this Aug 31, 2019
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update requests-mock from 1.5.0 to 1.5.2 (#120)
2ccb5e2
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu left review comments
@berkerpeksag berkerpeksag berkerpeksag requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@andrewnester @brettcannon @berkerpeksag @zhangyangyu @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.