GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups by flavianh · Pull Request #14976 · python/cpython

Conversation

@flavianh

@flavianh flavianh commented Jul 27, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fix for https://bugs.python.org/issue29553

Recreation of #117, updated to current master

https://bugs.python.org/issue29553

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 27, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jul 27, 2019
Flavian Hautbois @andrewnester
Fixed ArgumentParses format_usage for mutually exclusive groups.
e62cd6a
Co-authored-by: Andrew Nester <[email protected]>
@flavianh
flavianh force-pushed the bpo-29553-fix-format-usage branch from 9c364b5 to e62cd6a Compare July 27, 2019 09:42
@flavianh flavianh mentioned this pull request Jul 27, 2019
bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #117
Closed
@flavianh

flavianh commented Aug 2, 2019

Copy link
Copy Markdown
Author

Anyone available for a review? @brettcannon @berkerpeksag

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettcannon

brettcannon commented Aug 2, 2019

Copy link
Copy Markdown
Member

@flavianh I'm not clear as to why you specifically think I'm in a good position to review this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@flavianh

flavianh commented Aug 5, 2019

Copy link
Copy Markdown
Author

@brettcannon I added you because you commented on the PR I'm recreating. Didn't notice that it was an automatic message. Do you know who could review it? It's been lingering for 9 days

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettcannon

brettcannon commented Aug 9, 2019

Copy link
Copy Markdown
Member

@flavianh don't know sorry. I would try pinging the issue on bugs.python.org, and if you don't get a review within a week of doing that then email python-dev.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aeros aeros mentioned this pull request Aug 23, 2019
Write guidelines about closing PR/issue by triagers python/devguide#527
Closed
berkerpeksag added 2 commits August 25, 2019 21:28
@berkerpeksag
Update 2019-07-27-10-14-45.bpo-29553.TVeIDe.rst
24242e7
@berkerpeksag
Update test_argparse.py
b96c8b0
@berkerpeksag berkerpeksag added needs backport to 3.7 labels Aug 25, 2019
berkerpeksag
berkerpeksag approved these changes Aug 25, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 25, 2019
@berkerpeksag
berkerpeksag merged commit da27d9b into python:master Aug 25, 2019
@miss-islington

miss-islington commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Thanks @flavianh for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Aug 25, 2019
@miss-islington

miss-islington commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Sorry @flavianh and @berkerpeksag, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da27d9b9dc44913ffee8f28d9638985eaaa03755 3.8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned berkerpeksag Aug 25, 2019
@bedevere-bot

bedevere-bot commented Aug 25, 2019

Copy link
Copy Markdown

GH-15494 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Aug 25, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2019
Flavian Hautbois @miss-islington
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
cace43e
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <[email protected]>
(cherry picked from commit da27d9b)

Co-authored-by: Flavian Hautbois <[email protected]>
@berkerpeksag

berkerpeksag commented Aug 25, 2019

Copy link
Copy Markdown
Member

Thanks!

@flavianh would you like to create a backport PR for 3.8?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag pushed a commit that referenced this pull request Aug 25, 2019
@miss-islington @berkerpeksag
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
31ea447
…roups (GH-14976)

Co-authored-by: Andrew Nester <[email protected]>
Co-authored-by: Flavian Hautbois <[email protected]>

(cherry picked from commit da27d9b)
rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 30, 2019
@rhettinger
[3.8] bpo-29553: Fix ArgumentParser.format_usage() for mutually exclu…
3852021
…sive groups (pythonGH-14976) (pythonGH-15494)
rhettinger added a commit that referenced this pull request Aug 30, 2019
@rhettinger
[3.8] bpo-29553: Fix ArgumentParser.format_usage() for mutually exclu…
bd8ca9a
…sive groups (GH-14976) (GH-15494) (GH-15624)
@berkerpeksag berkerpeksag mentioned this pull request Aug 31, 2019
Alternarive for bpo-29553 - Fixed ArgumentParses format_usage for mutually exclusive groups #120
Closed
@flavianh

flavianh commented Sep 2, 2019

Copy link
Copy Markdown
Author

@berkerpeksag Sure, how do I go about that?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Flavian Hautbois @andrewnester @lisroach
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
6ffdad7
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <[email protected]>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Flavian Hautbois @andrewnester @DinoV
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
d5b1399
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <[email protected]>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Flavian Hautbois @andrewnester @websurfer5
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
2439169
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@berkerpeksag berkerpeksag

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@flavianh @brettcannon @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.