GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120417: Move imports to doctests in test_doctest by vstinner · Pull Request #120679 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove unused imports from the stdlib #120417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-120417: Move imports to doctests in test_doctest
5f6f390
@vstinner vstinner added the skip news label Jun 18, 2024
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2024
Remove unused imports from the stdlib #120417
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 18, 2024
@vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 18, 2024
gh-120417: Add #noqa: F401 to tests #120627
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Jun 18, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it is up to you what variant do you prefer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 18, 2024
@vstinner
vstinner merged commit d2e4231 into python:main Jun 18, 2024
@vstinner
vstinner deleted the test_doctest branch June 18, 2024 13:54
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2024
@vstinner

vstinner commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

But it is up to you what variant do you prefer.

This approach is more verbose than #noqa:F401, but IMO it's better to move imports where they are used.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@vstinner @picnixz
pythongh-120417: Move imports to doctests in test_doctest (python#120679
aae5a27 
)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-120417: Move imports to doctests in test_doctest (python#120679
41765b6 
)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-120417: Move imports to doctests in test_doctest (python#120679
eebd4d4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.