GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-122085: Use include files for `whatsnew/3.13.rst` deprecations by hugovk · Pull Request #121241 · python/cpython Conversation
| |||||||||||||||||||||||||||
|
What happens if an entry from "Pending Removal in Future Versions" moves to "Pending Removal in Python 3.16"? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Then we move it from |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Yes, but then it wouldn't show up in the list of future deprecations for 3.13 if 3.16 isn't included (which would be easy to forget when added). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Correct, when creating a new include file, you need to remember to add it to the relevant pages. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This only covers the C API, not the Python API. Is that intended? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
TODO: This was meant to be for the Python deprecations, not C API ones. I'll update it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
What will we do with the C API? Do we include it like this? Or do we put it in a separate file? .. include:: ../deprecations/pending-removal-in-3.14.rst :start-after: .. start_pending_removal_in_3_14_capi :end-before: .. end_pending_removal_in_3_14_capi |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No, I think it would be easier to have each in their own files (not necessarily named like this): |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
8a461c5 to
2e85df9
Compare
Updated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with one typo fix!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| @@ -1631,318 +1631,13 @@ New Deprecations | |||
|
|
|||
| .. Add deprecations above alphabetically, not here at the end. | |||
|
|
|||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a new "Pending removal" section, with a paragraph describing what "pending removal" means, and include the other files as subsections?
These are currently nested under "New Deprecation" (not sure if intentionally):

I also noticed that there are two "Pending Removal in Python 3.x", for each "x", e.g.:
Is this intentional?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I suggest not expanding the scope of the PR. Move the content in this one, rearrange the page later (and possibly only for 3.14).
I also noticed that there are two "Pending Removal in Python 3.x", for each "x", e.g.:
Yes, there are separate sections for Python API and C API, and they're not presented very clearly.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I followed up on this in the original issue:
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @hugovk, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit a1df1b4) Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-122038 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
whatsnew/3.13.rst deprecations
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-122038 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-122038 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.