GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122085: Use include files for C API deprecations by AA-Turner · Pull Request #109843 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 25, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--109843.org.readthedocs.build/

  • Issue: Docs: move deprecations into include files #122085

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner
AA-Turner requested a review from vstinner September 25, 2023 13:39
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
@AA-Turner AA-Turner mentioned this pull request Sep 25, 2023
GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section #109751
Merged
vstinner
vstinner reviewed Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member

If you move these sub-sections of the C API section, you should also move the other ones of the "main" Python section: moving "Pending Removal in Python 3.14" after Removal. What do you think?

Screenshot 2023-09-26 at 10-18-55 What’s New In Python 3 13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

Personally, I probably wouldn't as I think semantically it makes more sense to note the pending removals for Python APIs within the Deprecated section -- they are a concise list of how quickly readers will need to adapt to the new APIs.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member

they are a concise list

My concern is more that these lists are getting bigger at every Python version. Sometimes, I'm considering to create a sub-page of What's New in Python 3.13, since the document is so big, that people may give up to just start reading it. Deprecation/Removal only interest a minority of people.

The whole What's New in Python 3.13 takes 18 pages if I print it as PDF with my default browser configuration.


I don't have a strong opinon between:

  • Deprecations

    • Pending Removals ...
  • Removal

VERSUS:

  • Deprecations
  • Removal
  • Pending Removals ...

I would just prefer to have consistency between the (main) Python section and the C API Changes section.


If you prefer to have "Pending Removals ..." under the Deprecations section, please just make it consistent in the doc.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner closed this Sep 29, 2023
@AA-Turner
AA-Turner deleted the docs/whatsnew/c-api-3.13 branch September 29, 2023 08:16
@AA-Turner
AA-Turner restored the docs/whatsnew/c-api-3.13 branch September 29, 2023 08:52
@AA-Turner AA-Turner reopened this Sep 29, 2023
blaisep
blaisep approved these changes May 20, 2024
View reviewed changes

@blaisep blaisep left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is cleaner than before, thank you.
I can't confirm that the content is correct, I hope this gets merged soon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 20, 2024
@hugovk

hugovk commented May 21, 2024

Copy link
Copy Markdown
Member

My concern is more that these lists are getting bigger at every Python version. Sometimes, I'm considering to create a sub-page of What's New in Python 3.13, since the document is so big, that people may give up to just start reading it. Deprecation/Removal only interest a minority of people.

I agree with this.

I want us to have a static page of pending deprecations, so we don't need to worry synchronising across both pages (3.14.rst <-> 3.13.rst <-> 3.12.rst etc.) and branches (main <-> 3.13 <-> 3.12).

And we sometimes do forget to update them, for example #118947. Additionally, at some point a branch goes to security-fix only, and we can no longer update the What's New.

Then, in "What's New in Python 3.x", we should only list the deprecations newly added in that release.


Compare the pytest page:

  • https://docs.pytest.org/en/latest/deprecations.html

As a user of pytest, this is a useful one-stop page to look where I need to update my code.

I copied it for Pillow:

  • https://pillow.readthedocs.io/en/stable/deprecations.html

As a maintainer of Pillow, this is a useful one-stop page to look for old deprecations to remove in the next release.

blaisep reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@blaisep

blaisep commented May 21, 2024

Copy link
Copy Markdown
Contributor

(OK, I can see that there is more to this than I originally thought)

It seems like the current consensus is to have something like

Doc/whatsnew/deprecations/removal.rst
Doc/whatsnew/deprecations/removalpending.rst
Doc/whatsnew/deprecations/deprecations.rst

and possibly some Doc/whatsnew/deprecations/index.rst with a bit of .. toctree:: sugar sprinkles?
Shall I bring this up in the docs discord?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@blaisep blaisep mentioned this pull request May 21, 2024
Fix version number in use_load_tests deprecation reference #119151
Merged
@hugovk

hugovk commented Jul 1, 2024

Copy link
Copy Markdown
Member

Follow on from this. We discussed this on Discourse:

  • https://discuss.python.org/t/streamline-whats-new-by-moving-deprecations-and-removals-out-of-news/53997

And in the docs-community meeting last month, where we thought about using includes:

  • https://docs-community.readthedocs.io/en/latest/monthly-meeting/2024-06.html#python-project-documentation

  • https://discuss.python.org/t/streamline-whats-new-by-moving-deprecations-and-removals-out-of-news/53997/8

Please see PR #121241 to make a start on this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added 5 commits July 27, 2024 01:01
@AA-Turner
Split out C API pending removal from What's New in Python 3.12
20a7f42
@AA-Turner
Split out C API pending removal from What's New in Python 3.13
6fd9342
@AA-Turner
Add C-API pending removals to What's New in Python 3.14
0171dad
@AA-Turner
Suffix list items with 'instead.'
c106726
@AA-Turner
Move removal to Removed section
97193bc
@AA-Turner
AA-Turner force-pushed the docs/whatsnew/c-api-3.13 branch from fec9587 to 97193bc Compare July 27, 2024 00:21
@AA-Turner AA-Turner changed the title What's New in Python 3.13: Synchronise C API 'Pending Removal' with 3.12 GH-122085: Use include files for C API deprecations Jul 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 27, 2024
Docs: move deprecations into include files #122085
Closed
5 tasks done
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 27, 2024
@AA-Turner

AA-Turner commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

With apologies for the force-push, I have hijacked my own PR to use the include-file approach for the C API, whilst still doing the synchronisation.

I've split the work into individual commits, which should be somewhat easy to follow.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner and others added 2 commits July 27, 2024 01:37
@AA-Turner
Fix title level
54903df
@AA-Turner
Merge branch 'main' into docs/whatsnew/c-api-3.13
1bb321f
@hugovk hugovk changed the title GH-122085: Use include files for C API deprecations gh-122085: Use include files for C API deprecations Jul 27, 2024
@hugovk

hugovk commented Jul 27, 2024

Copy link
Copy Markdown
Member

Is it so that we weren't previously duplicating all the C API deprecations across What's New files?

This will mean the What's New pages will become even longer. But I suppose if we do it for the Python deprecations, that's an argument for also doing it for the C API ones too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Jul 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Is it so that we weren't previously duplicating all the C API deprecations across What's New files?

Almost all of the deprecations were in both 3.12 and 3.13, it was only 3.14 that was sparse, so I think it is worth both ensuring there's consistency and that we advertise the deprecations in all What's New pages.

A

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Jul 28, 2024

Copy link
Copy Markdown
Member

Would you like to add these includes to the new deprecations/index.rst from #122352?


I also realised we don't want .. include:: pending-removal-in-3.14.rst here in main (aka 3.14), we only want to list later versions:

cpython/Doc/deprecations/index.rst

Line 4 in b359f66

.. include:: pending-removal-in-3.14.rst

The backports are correct:

  • https://github.com/python/cpython/blob/3.13/Doc/deprecations/index.rst
  • https://github.com/python/cpython/blob/3.12/Doc/deprecations/index.rst

Please could you also remove that line at the same time?

AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added 3 commits July 29, 2024 19:31
@AA-Turner
Merge branch 'main' into docs/whatsnew/c-api-3.13
0691f0b
@AA-Turner
Update deprecations/index
363c236
@AA-Turner
Reword
b560041
@AA-Turner

AA-Turner commented Jul 29, 2024

Copy link
Copy Markdown
Member Author

Would you like to add these includes to the new deprecations/index.rst

Done

Please could you also remove that line at the same time?

Done

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes Jul 29, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 29, 2024
@AA-Turner
AA-Turner merged commit 76bdfa4 into python:main Jul 29, 2024
@AA-Turner
AA-Turner deleted the docs/whatsnew/c-api-3.13 branch July 29, 2024 21:20
@miss-islington-app

miss-islington-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 29, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76bdfa4cd02532519fb43ae91244e2b4b3650d78 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned AA-Turner Jul 29, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76bdfa4cd02532519fb43ae91244e2b4b3650d78 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 29, 2024
@AA-Turner
[3.13] pythonGH-122085: Use include files for C API deprecations (pyt…
6b47b87
…honGH-109843)

(cherry picked from commit 76bdfa4)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

GH-122422 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 29, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 29, 2024
@AA-Turner
[3.12] pythonGH-122085: Use include files for C API deprecations (pyt…
53d629a
…honGH-109843)

(cherry picked from commit 76bdfa4)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

GH-122423 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 29, 2024
AA-Turner added a commit that referenced this pull request Jul 29, 2024
@AA-Turner
[3.13] GH-122085: Use include files for C API deprecations (GH-109843) (
56340ee
#122422)

(cherry picked from commit 76bdfa4)
AA-Turner added a commit that referenced this pull request Jul 30, 2024
@AA-Turner
[3.12] GH-122085: Use include files for C API deprecations (GH-109843) (
dd86217
#122423)

(cherry picked from commit 76bdfa4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@hugovk hugovk hugovk approved these changes
+1 more reviewer
@blaisep blaisep blaisep approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @vstinner @hugovk @blaisep
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.