GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-118926: Better distinguish between pointer and arrays in interpreter generator by markshannon · Pull Request #121496 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jul 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a supporting PR for #121318.

The code generator treats stack items of type PyStackRef * the same as arrays, which is incorrect.
This PR fixes that.

  • Issue: GC may have inconsistent view of stacktop with deferred references #118926

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Better distinguish between pointer and arrays in interpreter generator
f09258e
@bedevere-app bedevere-app Bot mentioned this pull request Jul 8, 2024
GC may have inconsistent view of stacktop with deferred references #118926
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 8, 2024
@markshannon
Add type annotation
ef912af
@markshannon markshannon added the skip news label Jul 8, 2024
@markshannon
Fix type annotation
1b1d361
@markshannon
markshannon requested a review from Fidget-Spinner July 8, 2024 15:10
Fidget-Spinner
Fidget-Spinner approved these changes Jul 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 9, 2024
@markshannon
markshannon merged commit bf8686e into python:main Jul 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 9, 2024
@markshannon
markshannon deleted the code-gen-arrays-vs-pointers branch July 9, 2024 10:41
@markshannon
markshannon restored the code-gen-arrays-vs-pointers branch July 16, 2024 13:44
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@markshannon @estyxx
pythonGH-118926: Better distinguish between pointer and arrays in int…
ee7a613 
…erpreter generator (pythonGH-121496)
@markshannon
markshannon deleted the code-gen-arrays-vs-pointers branch August 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.