Description

Fidget-Spinner

opened on May 10, 2024

Issue body actions

In #118450, Sam pointed out that GC can occur at any Py_DECREF. With deferred references, we will need to traverse the object's stacks. The main problem is that frame->stacktop might not represent the true stacktop at a GC collection, because frame->stacktop is not set in between opcodes.

This requires either scanning the entire stack (not just up to stacktop), or deferring GC to safe points.

Linked PRs

• gh-118926: Deferred reference counting GC changes for free threading #121318
• GH-118926: Better distinguish between pointer and arrays in interpreter generator #121496
• gh-118926: Spill deferred references to stack in cases generator #122748

Activity

1. markshannon

   added a commit that references this issue on Jul 9, 2024

   GH-118926: Better distinguish between pointer and arrays in interpret…

   bf8686e
2. estyxx

   added a commit that references this issue on Jul 17, 2024

   pythonGH-118926: Better distinguish between pointer and arrays in int…

   ee7a613
3. markshannon

   closed this as completedin #122730on Aug 6, 2024
4. colesbury

   added a commit that references this issue on Aug 6, 2024

   pythongh-118926: Spill deferred references to stack in cases generator

   70272dc
5. colesbury

   reopened this on Aug 6, 2024
6. colesbury

   added a commit that references this issue on Aug 7, 2024

   gh-118926: Spill deferred references to stack in cases generator (#12…

   3e753c6
7. blhsing

   added a commit that references this issue on Aug 22, 2024

   pythongh-118926: Spill deferred references to stack in cases generator (

   6431127
8. JacobCoffee

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Oct 1, 2024
9. JacobCoffee commented on Oct 1, 2024

   

   JacobCoffee

   on Oct 1, 2024

   Member

   More actions

   hey @Fidget-Spinner is this good to close since the ref'd PRs are merged?
10. Fidget-Spinner commented on Oct 1, 2024

    

    Fidget-Spinner

    on Oct 1, 2024

    MemberAuthor

    More actions

    Yup
11. Fidget-Spinner

    closed this as completedon Oct 1, 2024

Issue actions