GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122255: Add black box tests in test_warnings by serhiy-storchaka · Pull Request #122227 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They are similar to white box tests for gh-86298 in test_importlib.

  • Issue: Use specs instead of just __loader__ in C code #86298
  • Issue: Warnings and errors specific to the C implementation of the warnings module #122255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-86298: Add black box tests in test_warnings
680eaef 
They are similar to white box tests in test_importlib.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2024
Use specs instead of just __loader__ in C code #86298
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 24, 2024
serhiy-storchaka added 2 commits July 24, 2024 17:11
@serhiy-storchaka
Test also with the Python implementation.
ef9cb0f
@serhiy-storchaka
Use "always" filter.
6c73ece
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 25, 2024
Warnings and errors specific to the C implementation of the warnings module #122255
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-86298: Add black box tests in test_warnings gh-122255: Add black box tests in test_warnings Aug 8, 2024
@serhiy-storchaka
serhiy-storchaka merged commit fe13c9b into python:main Aug 8, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 8, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 8, 2024
@serhiy-storchaka
serhiy-storchaka deleted the test_warnings-test_gh86298 branch August 8, 2024 07:35
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@serhiy-storchaka @miss-islington
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
6126b60 
They are similar to white box tests for pythongh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@serhiy-storchaka @miss-islington
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
2ed027a 
They are similar to white box tests for pythongh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 8, 2024

Copy link
Copy Markdown

GH-122818 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 8, 2024
@bedevere-app

bedevere-app Bot commented Aug 8, 2024

Copy link
Copy Markdown

GH-122819 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 8, 2024
gpshead pushed a commit that referenced this pull request Aug 9, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
46f973f 
…H-122818)

gh-122255: Add black box tests in test_warnings (GH-122227)

They are similar to white box tests for gh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Aug 14, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
c3ee1a7 
…H-122819)

They are similar to white box tests for gh-86298 in test_importlib.
(cherry picked from commit fe13c9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@serhiy-storchaka @blhsing
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
d591fcd 
They are similar to white box tests for pythongh-86298 in test_importlib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.