Description

brettcannon

opened on Oct 23, 2020

Issue body actions

BPO	42132
Nosy	@brettcannon, @corona10

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-10-23.22:16:01.448>
labels = ['interpreter-core', 'type-bug', '3.10']
title = 'Use specs instead of just __loader__ in C code'
updated_at = <Date 2020-10-24.16:28:23.690>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-10-24.16:28:23.690>
actor = 'corona10'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2020-10-23.22:16:01.448>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 42132
keywords = []
message_count = 1.0
messages = ['379483']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'corona10']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42132'
versions = ['Python 3.10']

Linked PRs

• gh-122255: Add black box tests in test_warnings #122227

Activity

1. brettcannon commented on Oct 23, 2020

   

   brettcannon

   on Oct 23, 2020

   MemberAuthor

   More actions

   _warnings.c, pylifecycle.c, and pythonrun.c all either use or set __loader__ but without also falling back on __spec__.
2. brettcannon

   added

   3.10 (EOL)end of lifeend of life

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Oct 23, 2020
3. ezio-melotti

   transferred this issue fromon Apr 10, 2022
4. serhiy-storchaka

   added

   topic-importlib

   on May 22, 2022
5. warsaw

   added

   sprint

   on Oct 3, 2022
6. warsaw commented on Oct 3, 2022

   

   warsaw

   on Oct 3, 2022

   Member

   More actions

   I'm going to take a look at these module attribute issues during the 2022 core sprint.
7. ezio-melotti

   added this to Sprinton Oct 3, 2022
8. ezio-melotti

   moved this to Todo in Sprinton Oct 3, 2022
9. warsaw commented on Oct 4, 2022

   

   warsaw

   on Oct 4, 2022

   Member

   More actions

   I have _warnings.c implemented and tested.
10. warsaw commented on Oct 4, 2022

    

    warsaw

    on Oct 4, 2022

    Member

    More actions

    I think there's nothing to do for pythonrun.c. These set __loader__ but not __spec__ directly, and the documentation outlines the expected semantics. If the documented semantics are incorrect, then there should be a separate tracking bug for that case.

    Looking at pylifecycle.c next.
11. 7 remaining items
12. jessecomeau87

    added a commit that references this issue on May 20, 2024

    PoC for checking both __loader__ and __spec__.loader

    37b581a
13. serhiy-storchaka

    added 2 commits that reference this issue on Jul 24, 2024

    pythongh-122191: Fix test_warnings failure if run with -Werror

    cdbc98d

    pythongh-86298: Add black box tests in test_warnings

    680eaef
14. serhiy-storchaka commented on Jul 25, 2024

    

    serhiy-storchaka

    on Jul 25, 2024

    Member

    More actions

    These warnings are only emitted for the C implementation. See #122255.
15. serhiy-storchaka

    added a commit that references this issue on Jul 25, 2024

    gh-122191: Fix test_warnings failure if run with -Werror (GH-122222)

    9b4fe9b
16. miss-islington

    added a commit that references this issue on Jul 25, 2024

    pythongh-122191: Fix test_warnings failure if run with -Werror (pytho…

    5c7c8f4
17. serhiy-storchaka

    added 3 commits that reference this issue on Jul 25, 2024

    [3.12] pythongh-122191: Fix test_warnings failure if run with -Werror (…

    8377c48

    [3.12] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…

    be5e229

    [3.13] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…

    94db4cc
18. serhiy-storchaka

    added a commit that references this issue on Aug 8, 2024

    gh-122255: Add black box tests in test_warnings (GH-122227)

    fe13c9b
19. miss-islington

    added 2 commits that reference this issue on Aug 8, 2024

    pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)

    6126b60

    pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)

    2ed027a
20. gpshead

    added a commit that references this issue on Aug 9, 2024

    [3.13] gh-122255: Add black box tests in test_warnings (GH-122227) (G…

    46f973f
21. serhiy-storchaka

    added a commit that references this issue on Aug 14, 2024

    [3.12] gh-122255: Add black box tests in test_warnings (GH-122227) (G…

    c3ee1a7
22. blhsing

    added a commit that references this issue on Aug 22, 2024

    pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)

    d591fcd

Issue actions