GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-122191: Fix test_warnings failure if run with -Werror (GH-122222) by serhiy-storchaka · Pull Request #122257 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

spec.loader is now required in the module globals (see gh-86298).
(cherry picked from commit 9b4fe9b)

  • Issue: test_warnings fails if run with -Werror #122191

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.12] pythongh-122191: Fix test_warnings failure if run with -Werror (…
8377c48 
…pythonGH-122222)

__spec__.loader is now required in the module globals (see pythongh-86298).
(cherry picked from commit 9b4fe9b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
test_warnings fails if run with -Werror #122191
Closed
@bedevere-app bedevere-app Bot added the skip news label Jul 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
gh-122191: Fix test_warnings failure if run with -Werror #122222
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 25, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 25, 2024 07:01
@serhiy-storchaka
serhiy-storchaka merged commit be5e229 into python:3.12 Jul 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 25, 2024
@serhiy-storchaka
serhiy-storchaka deleted the backport-9b4fe9b-3.12 branch October 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.