GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-122191: Fix test_warnings failure if run with -Werror by serhiy-storchaka · Pull Request #122222 · python/cpython

Conversation

serhiy-storchaka commented Jul 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

__spec__.loader is now required in the module globals (see gh-86298).

Issue: test_warnings fails if run with -Werror #122191

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-122191: Fix test_warnings failure if run with -Werror

cdbc98d

__spec__.loader is now required in the module globals (see pythongh-86298).

serhiy-storchaka added tests

Tests in the Lib/test dir

skip news needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Jul 24, 2024

bedevere-app Bot mentioned this pull request

Jul 24, 2024

test_warnings fails if run with -Werror #122191

Closed

bedevere-app Bot added the awaiting core review label

Jul 24, 2024

AlexWaygood reviewed

Jul 24, 2024

View reviewed changes

Comment thread

Lib/test/test_warnings/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestion from review.

2dee352

AlexWaygood reviewed

Jul 24, 2024

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like my suggestion had some typos. Slightly concerning that it passed anyway.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_warnings/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_warnings/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

2be8c31

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood approved these changes

Jul 24, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jul 24, 2024


          Ensure that get_source() was called.

serhiy-storchaka merged commit 9b4fe9b into python:main

Jul 25, 2024

bedevere-app Bot removed the awaiting merge label

Jul 25, 2024

miss-islington-app Bot commented Jul 25, 2024

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka deleted the test_warnings-test_issue31285 branch

July 25, 2024 06:57

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 25, 2024


          pythongh-122191: Fix test_warnings failure if run with -Werror (pytho…

5c7c8f4

…nGH-122222)

__spec__.loader is now required in the module globals (see pythongh-86298).
(cherry picked from commit 9b4fe9b)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington-app Bot commented Jul 25, 2024

Copy link

Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b4fe9b718f27352ba0c1cf1184f5b90d77d7df4 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Jul 25, 2024

Copy link

Copy Markdown

Member Author

Thank you for your review @AlexWaygood.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

Jul 25, 2024

bedevere-app Bot commented Jul 25, 2024

Copy link

Copy Markdown

GH-122256 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jul 25, 2024

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 25, 2024


          [3.12] pythongh-122191: Fix test_warnings failure if run with -Werror (…

8377c48

…pythonGH-122222)

__spec__.loader is now required in the module globals (see pythongh-86298).
(cherry picked from commit 9b4fe9b)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jul 25, 2024

Copy link

Copy Markdown

GH-122257 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jul 25, 2024

serhiy-storchaka added a commit that referenced this pull request

Jul 25, 2024


          [3.12] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…

be5e229

…22222) (GH-122257)

__spec__.loader is now required in the module globals (see gh-86298).
(cherry picked from commit 9b4fe9b)

serhiy-storchaka added a commit that referenced this pull request

Jul 25, 2024


          [3.13] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…

94db4cc

…22222) (GH-122256)

__spec__.loader is now required in the module globals (see gh-86298).
(cherry picked from commit 9b4fe9b)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka removed their assignment

Jul 15, 2026

Reviewers

AlexWaygood

AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Jul 25, 2024

Uh oh!

miss-islington-app Bot commented Jul 25, 2024

Uh oh!

serhiy-storchaka commented Jul 25, 2024

Uh oh!

bedevere-app Bot commented Jul 25, 2024

Uh oh!

bedevere-app Bot commented Jul 25, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhiy-storchaka commented Jul 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.