GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111201: fix auto-indent in pyrepl for muliple pound comments by wiggin15 · Pull Request #123196 · python/cpython

Conversation

@wiggin15

@wiggin15 wiggin15 commented Aug 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This commit fixes an issue where a line that contains a control flow statement (if, for, ..) but ends with a comment that starts with multiple "#" signs, will not auto-indent the next line.
This happened because last_char could be updated to one of the "#" signs, missing the actual last character before the comment.

  • Issue: A new Python REPL #111201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wiggin15
pythongh-111201: fix auto-indent in pyrepl for muliple pound comments
dbec792
@wiggin15
wiggin15 requested review from ambv, lysnikolaou and pablogsal as code owners August 21, 2024 09:32
@bedevere-app bedevere-app Bot mentioned this pull request Aug 21, 2024
A new Python REPL #111201
Closed
7 tasks done
@bedevere-app bedevere-app Bot added the awaiting review label Aug 21, 2024
pablogsal
pablogsal approved these changes Sep 3, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 3, 2024
@pablogsal pablogsal added awaiting review needs backport to 3.13 only security fixes skip news and removed awaiting merge labels Sep 3, 2024
@pablogsal
pablogsal enabled auto-merge (squash) September 3, 2024 12:46
@pablogsal pablogsal closed this Sep 3, 2024
auto-merge was automatically disabled September 3, 2024 12:46

Pull request was closed

@pablogsal pablogsal reopened this Sep 3, 2024
@pablogsal
pablogsal enabled auto-merge (squash) September 3, 2024 12:46
Yhg1s and others added 2 commits September 6, 2024 01:45
@Yhg1s
Merge branch 'main' into main
d2f1052
@ambv
Merge branch 'main' into main
585bf15
@pablogsal
pablogsal merged commit d683f49 into python:main Sep 6, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 6, 2024

Copy link
Copy Markdown

Thanks @wiggin15 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2024
@wiggin15 @miss-islington
pythongh-111201: fix auto-indent in pyrepl for muliple pound comments (…
6692d3e 
…pythonGH-123196)

(cherry picked from commit d683f49)

Co-authored-by: Arnon Yaari <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 6, 2024

Copy link
Copy Markdown

GH-123764 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 6, 2024
ambv pushed a commit that referenced this pull request Sep 6, 2024
@miss-islington @wiggin15
[3.13] gh-111201: fix auto-indent in pyrepl for muliple pound comments (
b221c5b 
GH-123196) (GH-123764)

(cherry picked from commit d683f49)

Co-authored-by: Arnon Yaari <[email protected]>
This was referenced Oct 23, 2024
REPL auto-indentation is wrong with comments #122237
Closed
gh-122237: Fix repl auto indentation wrong with comments #122383
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@wiggin15 @pablogsal @Yhg1s @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.