GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix syntax in generate_re_casefix.py by JelleZijlstra · Pull Request #122699 · python/cpython

Conversation

JelleZijlstra commented Aug 5, 2024

Copy link

Copy Markdown

Member

This was broken in gh-97963.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix syntax in generate_re_casefix.py

df99d8c

This was broken in pythongh-97963.

JelleZijlstra requested review from serhiy-storchaka and vstinner

August 5, 2024 18:19

bedevere-app Bot added the awaiting core review label

Aug 5, 2024

JelleZijlstra added skip issue skip news and removed awaiting core review labels

Aug 5, 2024

vstinner approved these changes

Aug 5, 2024

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting merge label

Aug 5, 2024

vstinner added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Aug 5, 2024

serhiy-storchaka approved these changes

Aug 6, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra merged commit b72c748 into python:main

Aug 6, 2024

miss-islington-app Bot commented Aug 6, 2024

Copy link

Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Aug 6, 2024

JelleZijlstra deleted the casefix branch

August 6, 2024 06:16

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 6, 2024


          Fix syntax in generate_re_casefix.py (pythonGH-122699)

725e5a1

This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>

bedevere-app Bot commented Aug 6, 2024

Copy link

Copy Markdown

GH-122721 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Aug 6, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 6, 2024


          Fix syntax in generate_re_casefix.py (pythonGH-122699)

62c3ca3

This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>

bedevere-app Bot commented Aug 6, 2024

Copy link

Copy Markdown

GH-122722 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Aug 6, 2024

JelleZijlstra added a commit that referenced this pull request

Aug 6, 2024


          [3.12] Fix syntax in generate_re_casefix.py (GH-122699) (#122722)

be88b3b

This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>

JelleZijlstra added a commit that referenced this pull request

Aug 6, 2024


          [3.13] Fix syntax in generate_re_casefix.py (GH-122699) (#122721)

35bf9c6

This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request

Aug 7, 2024


          Fix syntax in generate_re_casefix.py (python#122699)

13ee34f

This was broken in pythongh-97963.

blhsing pushed a commit to blhsing/cpython that referenced this pull request

Aug 22, 2024


          Fix syntax in generate_re_casefix.py (python#122699)

b8f1bc1

This was broken in pythongh-97963.

Reviewers

vstinner

vstinner approved these changes

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.