GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97669: Create Tools/build/ directory by vstinner · Pull Request #97963 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Create Tools/build/ directory. Move the following scripts from Tools/scripts/ to Tools/build/:

  • check_extension_modules.py
  • deepfreeze.py
  • freeze_modules.py
  • generate_global_objects.py
  • generate_levenshtein_examples.py
  • generate_opcode_h.py
  • generate_re_casefix.py
  • generate_sre_constants.py
  • generate_stdlib_module_names.py
  • generate_token.py
  • parse_html5_entities.py
  • smelly.py
  • stable_abi.py
  • umarshal.py
  • update_file.py
  • verify_ensurepip_wheels.py
  • Issue: Remove outdated Tools/scripts/ example scripts #97669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@vstinner vstinner mentioned this pull request Oct 6, 2022
Remove outdated Tools/scripts/ example scripts #97669
Closed
@vstinner

vstinner commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Update: I added generate_levenshtein_examples.py.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Update: add freeze_modules.py.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner added the skip news label Oct 6, 2022
@JulienPalard

JulienPalard commented Oct 7, 2022

Copy link
Copy Markdown
Member

To avoid the documentation check issues, you'll have to rebase on top of main, sorry for the noise :(((

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

PR rebased to get fixes for the Docs CI job.

JulienPalard reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner marked this pull request as ready for review October 12, 2022 08:15
@vstinner
vstinner requested review from a team, ezio-melotti, lysnikolaou, pablogsal and tiran as code owners October 12, 2022 08:15
ezio-melotti
ezio-melotti reviewed Oct 12, 2022
View reviewed changes
Comment thread Tools/build/parse_html5_entities.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
gh-97669: Create Tools/build/ directory
751eafb
Create Tools/build/ directory. Move the following scripts from
Tools/scripts/ to Tools/build/:

* check_extension_modules.py
* deepfreeze.py
* freeze_modules.py
* generate_global_objects.py
* generate_levenshtein_examples.py
* generate_opcode_h.py
* generate_re_casefix.py
* generate_sre_constants.py
* generate_stdlib_module_names.py
* generate_token.py
* parse_html5_entities.py
* smelly.py
* stable_abi.py
* umarshal.py
* update_file.py
* verify_ensurepip_wheels.py

Update references to these scripts.
@vstinner

vstinner commented Oct 12, 2022

Copy link
Copy Markdown
Member Author

Update: I added verify_ensurepip_wheels.py. Technically, it's not directly required to build Python, but it's used by the workflow (CI).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Oct 14, 2022

Copy link
Copy Markdown
Member Author

@tiran @erlend-aasland: Currently, these scripts are installed on Linux and macOS. IMO they are useful outside Python itself. So I propose to move them into a dedicated directory.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Oct 17, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 17, 2022
@vstinner
vstinner merged commit 1863302 into python:main Oct 17, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 17, 2022
@vstinner
vstinner deleted the tools_build branch October 17, 2022 10:01
@vstinner

vstinner commented Oct 17, 2022

Copy link
Copy Markdown
Member Author

erlend-aasland approved these changes 2 hours ago

Thanks for the review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
@carljm
Merge branch 'main' into typewatch
cdbe93b
* main: (31 commits)
  pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
  pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
  Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
  pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
  pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
  pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
  pythongh-97669: Create Tools/build/ directory (python#97963)
  pythongh-95534: Improve gzip reading speed by 10% (python#97664)
  pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
  pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
  pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
  pythongh-85525: Remove extra row in doc (python#98337)
  pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
  pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
  pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
  pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
  pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
  pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
  Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
  [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
  ...
@encukou encukou mentioned this pull request May 30, 2023
Instructions for adding a new definition to the limited API don't work on platforms without make python/devguide#1102
Closed
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Aug 5, 2024
@JelleZijlstra
Fix syntax in generate_re_casefix.py
df99d8c
This was broken in pythongh-97963.
@JelleZijlstra JelleZijlstra mentioned this pull request Aug 5, 2024
Fix syntax in generate_re_casefix.py #122699
Merged
JelleZijlstra added a commit that referenced this pull request Aug 6, 2024
@JelleZijlstra
Fix syntax in generate_re_casefix.py (#122699)
b72c748
This was broken in gh-97963.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
@JelleZijlstra @miss-islington
Fix syntax in generate_re_casefix.py (pythonGH-122699)
725e5a1
This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>
This was referenced Aug 6, 2024
[3.13] Fix syntax in generate_re_casefix.py (GH-122699) #122721
Merged
[3.12] Fix syntax in generate_re_casefix.py (GH-122699) #122722
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
@JelleZijlstra @miss-islington
Fix syntax in generate_re_casefix.py (pythonGH-122699)
62c3ca3
This was broken in pythongh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra added a commit that referenced this pull request Aug 6, 2024
@miss-islington @JelleZijlstra
[3.12] Fix syntax in generate_re_casefix.py (GH-122699) (#122722)
be88b3b
This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra added a commit that referenced this pull request Aug 6, 2024
@miss-islington @JelleZijlstra
[3.13] Fix syntax in generate_re_casefix.py (GH-122699) (#122721)
35bf9c6
This was broken in gh-97963.
(cherry picked from commit b72c748)

Co-authored-by: Jelle Zijlstra <[email protected]>
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@JelleZijlstra @brandtbucher
Fix syntax in generate_re_casefix.py (python#122699)
13ee34f
This was broken in pythongh-97963.
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@JelleZijlstra @blhsing
Fix syntax in generate_re_casefix.py (python#122699)
b8f1bc1
This was broken in pythongh-97963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @JulienPalard @erlend-aasland @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.