GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122681: remove m_atan2()/c_atan2() helpers by skirpichev · Pull Request #122715 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2) #122681

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-122681: remove m_atan2()/c_atan2() helpers
c096fad
@bedevere-app bedevere-app Bot mentioned this pull request Aug 6, 2024
Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2) #122681
Closed
@skirpichev skirpichev mentioned this pull request Aug 6, 2024
gh-122681: merge m_atan2() and c_atan2() helper functions #122682
Merged
@skirpichev

This comment was marked as outdated.

Sign in to view
@vstinner vstinner added the skip news label Aug 6, 2024
@vstinner

vstinner commented Aug 6, 2024

Copy link
Copy Markdown
Member

Can you rebase/merge your branch to avoid the merge conflict? Then I can run buildbots on this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
Merge branch 'master' into remove-atan2-helpers-122681
a4aff45
@skirpichev
skirpichev marked this pull request as ready for review August 6, 2024 12:52
@bedevere-app bedevere-app Bot added the awaiting review label Aug 6, 2024
@skirpichev

This comment was marked as outdated.

Sign in to view
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024
@bedevere-bot

bedevere-bot commented Aug 6, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a4aff45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024
@skirpichev

skirpichev commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

No failures, related to this pr.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Aug 7, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skirpichev: Did you just create to see if removing the wrapper would work or not, or do you propose to remove it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 7, 2024
@skirpichev

skirpichev commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

Yeah, I think we can remove it; testing with buildbots - for additional safety. But it's not urgent and I would appreciate @mdickinson blessing.

Current workarounds fix only few functions in cmath. Missing bugreports - another indication, that underlying problems were fixed on affected systems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
Merge branch 'main' into remove-atan2-helpers-122681
11a6f3d
kumaraditya303
kumaraditya303 approved these changes Aug 17, 2024
View reviewed changes
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024
@bedevere-bot

bedevere-bot commented Aug 17, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 11a6f3d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024
@kumaraditya303
kumaraditya303 merged commit 19be0ee into python:main Aug 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 17, 2024
@skirpichev
skirpichev deleted the remove-atan2-helpers-122681 branch August 17, 2024 08:26
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@skirpichev @jeremyhylton
pythongh-122681: remove m_atan2()/c_atan2() helpers (python#122715)
a5f57ab
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@skirpichev @blhsing
pythongh-122681: remove m_atan2()/c_atan2() helpers (python#122715)
d7d56eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@skirpichev @vstinner @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.