GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-120024: Refactor code generators to uses classes for emitting code. by markshannon · Pull Request #122730 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Aug 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refactor the replacement functions and lookup tables into classes.
This is necessary to support future mixins for the emitter classes to support different RC deferral schemes.
The first such scheme will be to fix #118926

This is strictly a refactoring. It adds no new functionality and the output of the code generators is unchanged.

  • Issue: Deferred reference counts #120024

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Refactor code generators to uses classes for emitting code.
8652cec
@bedevere-app bedevere-app Bot mentioned this pull request Aug 6, 2024
Deferred reference counts #120024
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 6, 2024
@markshannon markshannon added the skip news label Aug 6, 2024
iritkatriel
iritkatriel approved these changes Aug 6, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 6, 2024
@markshannon
markshannon merged commit fbfab4f into python:main Aug 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 6, 2024
@markshannon
markshannon deleted the refactor_code_generator branch August 6, 2024 12:04
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@markshannon @brandtbucher
pythonGH-120024: Refactor code generators to uses classes for emittin…
d886c1b 
…g code. (pythonGH-122730)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@markshannon @blhsing
pythonGH-120024: Refactor code generators to uses classes for emittin…
22d62e6 
…g code. (pythonGH-122730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GC may have inconsistent view of stacktop with deferred references

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.