GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-123085: Fix issue in inferred caller when resources package has no source (GH-123102) by jaraco · Pull Request #124021 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Sep 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

gh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resources#314). (cherry picked from commit a53812d)

Backport of gh-123102.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
[3.12] pythongh-123085: Fix issue in inferred caller when resources p…
70b4561 
…ackage has no source (pythonGH-123102)

pythongh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resourcesGH-314).
(cherry picked from commit a53812d)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco
jaraco requested review from FFY00 and warsaw as code owners September 12, 2024 20:03
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 12, 2024
This was referenced Sep 12, 2024
gh-123085: Fix issue in inferred caller when resources package has no source #123102
Merged
importlib.resources.files() doesn't work correctly when importlib library is compiled #123085
Open
@jaraco
Merge branch '3.12' into backport-a53812d-3.12
1f1afdd
@jaraco

jaraco commented Jan 5, 2025

Copy link
Copy Markdown
Member Author

The docs build failure appears unrelated to these changes, so I plan to ignore them if possible.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit d712ece into python:3.12 Jan 5, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 5, 2025
@encukou

encukou commented Jan 7, 2025

Copy link
Copy Markdown
Member

This breaks some buildbots, like a Debian one here: https://buildbot.python.org/#/builders/1248/builds/1102
I guess #124131 is needed for 3.12 as well
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 7, 2025
@erlend-aasland
pythongh-123085: Remove double 'import os' added by PR python#124021
358cbc7
@erlend-aasland erlend-aasland mentioned this pull request Jan 7, 2025
[3.12] gh-123085: Remove double 'import os' added by PR #124021 #128600
Merged
jaraco pushed a commit that referenced this pull request Jan 8, 2025
@erlend-aasland
[3.12] gh-123085: Remove double 'import os' added by PR #124021 (#128600
b46adda 
)

gh-123085: Remove double 'import os' added by PR #124021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaraco @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.