GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102511: Change the `os.path.splitroot` param name from `path` back to `p` by sobolevn · Pull Request #124097 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs #118089

CC @nineteendo

Now it is in sync with the Python version here:

  • cpython/Lib/posixpath.py

    Line 141 in 401fff7

    def splitroot(p):

  • cpython/Lib/ntpath.py

    Line 172 in 401fff7

    def splitroot(p):
  • Issue: Add C implementation of os.path.splitroot() #102511

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-102511: Change the os.path.splitroot param name from `path…
2daf748 
…` back to `p`
@sobolevn
sobolevn requested review from barneygale, hugovk and zooba September 15, 2024 08:18
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2024
Add C implementation of os.path.splitroot() #102511
Closed
@sobolevn sobolevn added skip news needs backport to 3.13 only security fixes labels Sep 15, 2024
picnixz
picnixz approved these changes Sep 15, 2024
View reviewed changes
@nineteendo

nineteendo commented Sep 15, 2024

Copy link
Copy Markdown
Contributor

Thanks, I didn't notice this. I was too focused on the difficult aspects of the PR.
sobolevn reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 3b6bfa7 into python:main Sep 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3b6bfa77aa4da2ce1f3a15e39831f8b85882698c 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned zooba Sep 18, 2024
@zooba

zooba commented Sep 18, 2024

Copy link
Copy Markdown
Member

Backport should wait for 3.13.1 anyway, so we'll rebase it then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware zware mentioned this pull request Sep 18, 2024
Fix make htmllive target #124219
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@sobolevn @savannahostrowski
pythongh-102511: Change the os.path.splitroot param name from `path…
3c9475b 
…` back to `p` (pythonGH-124097)
@bedevere-app

bedevere-app Bot commented Oct 3, 2024

Copy link
Copy Markdown

GH-124919 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 3, 2024
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 3, 2024
@sobolevn @JelleZijlstra
[3.13] pythongh-102511: Change the os.path.splitroot param name fro…
8a0285b 
…m `path` back to `p` (pythonGH-124097)

(cherry picked from commit 3b6bfa7)

Co-authored-by: sobolevn <[email protected]>
@JelleZijlstra

JelleZijlstra commented Oct 3, 2024

Copy link
Copy Markdown
Member

I opened the backport PR just so this doesn't get lost, the conflict was in clinic output only.
nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added a commit that referenced this pull request Oct 8, 2024
@JelleZijlstra @sobolevn
[3.13] gh-102511: Change the os.path.splitroot param name from `pat…
761c3b2 
…h` back to `p` (GH-124097) (#124919)

(cherry picked from commit 3b6bfa7)

Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@barneygale barneygale Awaiting requested review from barneygale
@hugovk hugovk Awaiting requested review from hugovk
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @nineteendo @zooba @JelleZijlstra @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.