GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124487: Require at least Windows 10 SDK and for install by zooba · Pull Request #124672 · python/cpython

Conversation

@zooba

@zooba zooba commented Sep 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Python-3.13.0rc2 cannot build in windows 11 with visual studio 2022 and windows sdk 10.0.26100 #124487

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-124487: Require at least Windows 10 SDK and for install
02fdba6
@zooba
zooba requested a review from a team as a code owner September 27, 2024 14:08
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2024
Python-3.13.0rc2 cannot build in windows 11 with visual studio 2022 and windows sdk 10.0.26100 #124487
Closed
@zooba
Correct syntax
dff541b
@zooba zooba added the needs backport to 3.13 only security fixes label Sep 27, 2024
@zooba

zooba commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

#124676 is an alternative fix that might be considered for 3.13 instead of this one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba removed the needs backport to 3.13 only security fixes label Sep 27, 2024
Wulian233
Wulian233 reviewed Sep 28, 2024
View reviewed changes

@Wulian233 Wulian233 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the minimum installation requirement for PR now Win10? If yes, I think the FailureOldOS information needs to be changed as well

https://github.com/search?q=repo%3Apython%2Fcpython%20FailureOldOS&type=code

At least Windows 8.1 or Windows Server 2012 are required to install

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread PC/pyconfig.h.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233 Wulian233 mentioned this pull request Sep 30, 2024
gh-124102: Update internal PCbuild docs and correct WiX registry #124784
Merged
zooba and others added 2 commits September 30, 2024 16:46
@zooba @Wulian233
Update PC/pyconfig.h.in
2a28de2 
Co-authored-by: Wulian <[email protected]>
@zooba
Update installer string
adc9850
@zooba

zooba commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

Thanks for the review! Good catches
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Merge branch 'pythongh-124487' of https://github.com/zooba/cpython into
328348f 
pythongh-124487
@zooba
zooba merged commit fac5e7a into python:main Sep 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 30, 2024
@zooba
zooba deleted the gh-124487 branch September 30, 2024 17:50
@Wulian233 Wulian233 mentioned this pull request Oct 1, 2024
remove win7 and win8 msu python/cpython-bin-deps#5
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Wulian233 Wulian233 Wulian233 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zooba @Wulian233
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.