GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-124487: Update Windows API version to Windows 8.1 by zooba · Pull Request #124676 · python/cpython

Conversation

@zooba

@zooba zooba commented Sep 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Python-3.13.0rc2 cannot build in windows 11 with visual studio 2022 and windows sdk 10.0.26100 #124487

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-124487: Update Windows API version to Windows 8.1
ef3b812
@zooba
zooba requested a review from a team as a code owner September 27, 2024 14:59
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2024
Python-3.13.0rc2 cannot build in windows 11 with visual studio 2022 and windows sdk 10.0.26100 #124487
Closed
@zooba zooba mentioned this pull request Sep 27, 2024
gh-124487: Require at least Windows 10 SDK and for install #124672
Merged
@Yhg1s
Yhg1s merged commit a4916e6 into python:3.12 Sep 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 27, 2024
@zooba zooba added the needs backport to 3.13 only security fixes label Sep 27, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@zooba @miss-islington
[3.12] pythongh-124487: Update Windows API version to Windows 8.1 (py…
28c8549 
…thonGH-124676)

(cherry picked from commit a4916e6)

Co-authored-by: Steve Dower <[email protected]>
pythongh-124487: Update Windows API version to Windows 8.1
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124702 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 27, 2024
@zooba
zooba deleted the gh-124487-3.12 branch September 27, 2024 19:07
@bedevere-app

bedevere-app Bot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124702 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @zooba
[3.13] gh-124487: Update Windows API version to Windows 8.1 (GH-124676)…
09aecb6 
… (#124702)

gh-124487: Update Windows API version to Windows 8.1 (GH-124676)
(cherry picked from commit a4916e6)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 27, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.13 has failed when building commit 09aecb6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1590/builds/22) and take a look at the build logs.
  4. Check if the failure is related to this commit (09aecb6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1590/builds/22

Failed tests:

  • test_android

Failed subtests:

  • test_rate_limit - test.test_android.TestAndroidOutput.test_rate_limit

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.13/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 88.82680452107101 != 100 within 10.0 delta (11.173195478928989 difference)


Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.13/test/test_android.py", line 424, in test_rate_limit
    self.assertAlmostEqual(
    ~~~~~~~~~~~~~~~~~~~~~~^
        write_bucketful(), MAX_KB_PER_SECOND,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        delta=MAX_KB_PER_SECOND * 0.1
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 111.25592844486414 != 100 within 10.0 delta (11.25592844486414 difference)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith

mhsmith commented Sep 28, 2024

Copy link
Copy Markdown
Member

Unrelated buildbot failure – will be fixed by #124035.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@peachismomo peachismomo mentioned this pull request Jul 3, 2026
fix: CI/CD build fail for arm64 windows OrcaSlicer/OrcaSlicer#14556
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @bedevere-bot @mhsmith @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.