GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112088: aclocal version is updated to 1.16.5 in docs by efimov-mikhail · Pull Request #125457 · python/cpython

Conversation

@efimov-mikhail

@efimov-mikhail efimov-mikhail commented Oct 14, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @vstinner

  • Issue: Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088

📚 Documentation preview 📚: https://cpython-previews--125457.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@efimov-mikhail
pythongh-112088: aclocal version is updated to 1.16.5 in docs
3f67be2
@efimov-mikhail
efimov-mikhail requested review from corona10 and erlend-aasland as code owners October 14, 2024 14:20
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2024
Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088
Closed
vstinner
vstinner reviewed Oct 14, 2024
View reviewed changes
Comment thread Doc/using/configure.rst Outdated
Autoconf 2.71, aclocal 1.16.4 and SQLite 3.15.2 are now required.

.. versionchanged:: 3.13
Require aclocal 1.16.5.

@vstinner vstinner Oct 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the previous 3.13 entry instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@efimov-mikhail efimov-mikhail Oct 14, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was stupid error.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner reviewed Oct 14, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated
* Autoconf 2.71 and aclocal 1.16.5 are now required to regenerate
the :file:`configure` script.
(Contributed by Christian Heimes in :gh:`89886`.)
(Contributed by Victor Stinner in :gh:`112090`.)

@vstinner vstinner Oct 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep Christian, I didn't require autoconf 2.71 in d9fd33a.

Something like:

(Contributed by Christian Heimes in :gh:`89886` and by Victor Stinner in :gh:`112090`.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@efimov-mikhail
Fixes after review
d774ef8
@efimov-mikhail
efimov-mikhail requested a review from vstinner October 14, 2024 14:47
@vstinner
vstinner merged commit 45df264 into python:main Oct 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 14, 2024
@vstinner vstinner added the needs backport to 3.13 only security fixes label Oct 14, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2024
@efimov-mikhail @miss-islington
pythongh-112088: aclocal version is updated to 1.16.5 in docs (python…
ee65431 
…GH-125457)

(cherry picked from commit 45df264)

Co-authored-by: Mikhail Efimov <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

GH-125459 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 14, 2024
vstinner pushed a commit that referenced this pull request Oct 14, 2024
@miss-islington @efimov-mikhail
[3.13] gh-112088: aclocal version is updated to 1.16.5 in docs (GH-12…
6c81928 
…5457) (#125459)

gh-112088: aclocal version is updated to 1.16.5 in docs (GH-125457)
(cherry picked from commit 45df264)

Co-authored-by: Mikhail Efimov <[email protected]>
@efimov-mikhail
efimov-mikhail deleted the aclocal_version_update branch October 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@efimov-mikhail @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.