GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109413: Enable `strict_optional` for `libregrtest/main.py` by sobolevn · Pull Request #126394 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I also enabled return error code and fix two problems with it.
I decided to split strict_optional PRs based on modules for easier reviews :)

  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-109413: Enable strict_optional for libregrtest/main.py
f420397
@sobolevn
sobolevn requested a review from AlexWaygood November 4, 2024 11:57
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2024
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@sobolevn sobolevn added skip news needs backport to 3.13 only security fixes labels Nov 4, 2024
AlexWaygood
AlexWaygood reviewed Nov 4, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
c7bd2a6
AlexWaygood
AlexWaygood approved these changes Nov 4, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 4, 2024
vstinner
vstinner reviewed Nov 7, 2024
View reviewed changes
Comment thread Lib/test/libregrtest/main.py Outdated

@property
def tmp_dir(self) -> StrPath:
assert self._tmp_dir is not None, (

@vstinner vstinner Nov 7, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace asssert with if+raise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added 2 commits November 11, 2024 10:08
@sobolevn
Address review
d82dc7c
@sobolevn
Address review
4cf8ae5
vstinner
vstinner approved these changes Nov 13, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
sobolevn merged commit 12ca7e6 into python:main Nov 13, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 13, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 13, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 13, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 12ca7e622ff21ba3b7c90c62be6f6f82d543f25b 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned sobolevn Nov 13, 2024
@sobolevn

sobolevn commented Nov 13, 2024

Copy link
Copy Markdown
Member Author

I will do a manual backport in a moment.
Thanks everyone!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Nov 13, 2024

Copy link
Copy Markdown

GH-126802 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 13, 2024
sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 13, 2024
@sobolevn
[3.13] pythongh-109413: Enable strict_optional for `libregrtest/mai…
e6475e9 
…n.py` (pythonGH-126394)

(cherry picked from commit 12ca7e6)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Nov 14, 2024
@sobolevn
[3.13] gh-109413: Enable strict_optional for libregrtest/main.py (G…
effedb5 
…H-126394) (#126802)

(cherry picked from commit 12ca7e6)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@sobolevn @picnixz
pythongh-109413: Enable strict_optional for libregrtest/main.py (p…
4157281 
…ython#126394)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@sobolevn @ebonnal
pythongh-109413: Enable strict_optional for libregrtest/main.py (p…
440b7e9 
…ython#126394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @vstinner @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.