GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109413: Enable mypy's `disallow_any_generics` setting when checking `libregrtest` by sobolevn · Pull Request #127033 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixing some low-hanging fruits, which can be fixed without many modifications.

  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn sobolevn added skip news needs backport to 3.13 only security fixes labels Nov 19, 2024
@sobolevn
sobolevn requested review from AlexWaygood and vstinner November 19, 2024 18:21
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Nov 19, 2024
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@sobolevn
pythongh-109413: Remove disallow_any_generics and `ignore-without-c…
852bc17 
…ode` from `libregrtest/mypy.ini`
@sobolevn
sobolevn force-pushed the issue-109413-flags branch from 54a4e58 to 852bc17 Compare November 19, 2024 18:22
@AlexWaygood AlexWaygood changed the title gh-109413: Remove disallow_any_generics and ignore-without-code from libregrtest/mypy.ini gh-109413: Enable mypy's disallow_any_generics setting when checking libregrtest Nov 19, 2024
AlexWaygood
AlexWaygood approved these changes Nov 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 19, 2024
@sobolevn
sobolevn merged commit 824afbf into python:main Nov 19, 2024
@miss-islington-app

miss-islington-app Bot commented Nov 19, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2024
@sobolevn @miss-islington
pythongh-109413: Enable mypy's disallow_any_generics setting when c…
13675e2 
…hecking `libregrtest` (pythonGH-127033)

(cherry picked from commit 824afbf)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 19, 2024

Copy link
Copy Markdown

GH-127034 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 19, 2024
sobolevn added a commit that referenced this pull request Nov 24, 2024
@miss-islington @sobolevn
[3.13] gh-109413: Enable mypy's disallow_any_generics setting when …
24b8630 
…checking `libregrtest` (GH-127033) (#127034)

gh-109413: Enable mypy's `disallow_any_generics` setting when checking `libregrtest` (GH-127033)
(cherry picked from commit 824afbf)

Co-authored-by: sobolevn <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@sobolevn @ebonnal
pythongh-109413: Enable mypy's disallow_any_generics setting when c…
ef2ea26 
…hecking `libregrtest` (python#127033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.