GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87138: convert blake2b/2s types to heap types by picnixz · Pull Request #127669 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a follow-up to #26374.

  • Issue: [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
convert blake2b/2s types to heap types
0130ab8
@picnixz
picnixz requested review from gpshead and tiran as code owners December 6, 2024 09:34
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2024
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2024
@picnixz picnixz added the skip news label Dec 6, 2024
kumaraditya303
kumaraditya303 reviewed Dec 7, 2024
View reviewed changes
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Reduce diff
9b40742
kumaraditya303
kumaraditya303 reviewed Dec 7, 2024
View reviewed changes
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz commented Dec 7, 2024
View reviewed changes
Comment thread Modules/blake2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Update Modules/blake2module.c
37cb7f3
kumaraditya303
kumaraditya303 approved these changes Dec 26, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 26, 2024
@kumaraditya303
kumaraditya303 merged commit fb0b942 into python:main Dec 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 26, 2024
@picnixz
picnixz deleted the feat/hashlib/blake/heap-type-87138 branch December 26, 2024 15:38
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @srinivasreddy
pythongh-87138: convert blake2b/2s types to heap types (python#127669)
ab07c97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran
+1 more reviewer
@neonene neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @neonene @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.