GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42972: Fully support GC for hashlib heap types (GH-26374) by erlend-aasland · Pull Request #26374 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 25, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 4 commits May 26, 2021 00:01
Erlend E. Aasland
bpo-42972: Fully support GC for sha256 heap types
186562f
Erlend E. Aasland
bpo-42972: Fully support GC for sha512 heap types
b2817ab
Erlend E. Aasland
bpo-42972: Fully support GC for sha1 heap types
b381665
Erlend E. Aasland
bpo-42972: Fully support GC for md5 heap types
49226dd
@erlend-aasland
erlend-aasland requested a review from tiran as a code owner May 25, 2021 22:14
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2021
@bedevere-bot bedevere-bot added the awaiting review label May 25, 2021
@erlend-aasland erlend-aasland added needs backport to 3.10 skip news labels May 25, 2021
@tiran tiran assigned gpshead and tiran May 26, 2021
@tiran
tiran requested a review from gpshead May 26, 2021 14:55
tiran
tiran approved these changes May 26, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 26, 2021
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran

tiran commented May 26, 2021

Copy link
Copy Markdown
Member

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

I've never seen this, but it does look like an infrastructure issue; the builds/tests did not fail, they were cancelled.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 26, 2021

Copy link
Copy Markdown
Member

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

That happens when the server restarts with an update, which happened because @vstinner updated the IRC configuration
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
gpshead
gpshead approved these changes May 26, 2021
View reviewed changes
@tiran tiran added the 🤖 automerge label May 27, 2021
@tiran tiran changed the title bpo-42972: Fully support GC for hashlib heap types bpo-42972: Fully support GC for hashlib heap types (GH-26374) May 27, 2021
@tiran
tiran merged commit 6ef5ba3 into python:main May 27, 2021
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 27, 2021
@tiran tiran removed the 🤖 automerge label May 27, 2021
@bedevere-bot

bedevere-bot commented May 27, 2021

Copy link
Copy Markdown

GH-26398 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
Erlend Egeberg Aasland @miss-islington
bpo-42972: Fully support GC for hashlib heap types (pythonGH-26374)
0f2ec18 
(cherry picked from commit 6ef5ba3)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland
erlend-aasland deleted the bpo-42972/sha256 branch May 27, 2021 07:52
@erlend-aasland

erlend-aasland commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @gpshead and @tiran! 🙏🏻
tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 27, 2021
@miss-islington
[3.10] bpo-42972: Fully support GC for hashlib heap types (GH-26374) (G…
4431922 
…H-26398)

(cherry picked from commit 6ef5ba3)


Co-authored-by: Erlend Egeberg Aasland <[email protected]>

Automerge-Triggered-By: GH:tiran
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
This was referenced Dec 6, 2024
gh-87138: convert blake2b/2s types to heap types #127669
Merged
gh-87138: convert SHA-3 object type to heap type #127670
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

@tiran tiran

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@erlend-aasland @bedevere-bot @tiran @pablogsal @miss-islington @gpshead @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.