GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87138: convert SHA-3 object type to heap type by picnixz · Pull Request #127670 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a follow-up to #26374.

I took the liberty of:

  • adding an assert() on the rate
  • removing a redundant if (my IDE would warn me! and PyMem_Free() already checks for NULL)
  • suppress the return type of _sha3_clear() to make the IDE happy as well.
  • Issue: [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 2 commits December 4, 2024 16:53
@picnixz
remove redundant casts
cd2c97f
@picnixz
convert SHA3 and SHAKE classes to heap types
a8975ed
@picnixz
picnixz requested review from gpshead and tiran as code owners December 6, 2024 09:35
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2024
[C API] Heap types (PyType_FromSpec) must fully implement the GC protocol #87138
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2024
@picnixz picnixz added the skip news label Dec 6, 2024
picnixz added 2 commits December 8, 2024 14:13
@picnixz
Revert "remove redundant casts"
94a6460 
This reverts commit cd2c97f.
@picnixz
remove cosmetics
e23eeee
@picnixz
picnixz force-pushed the feat/hashlib/sha3/heap-type-87138 branch from acbe3d1 to e23eeee Compare December 8, 2024 13:18
gpshead
gpshead approved these changes Dec 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 8, 2024
@gpshead gpshead self-assigned this Dec 8, 2024
@gpshead
gpshead merged commit 3b78409 into python:main Dec 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 8, 2024
@picnixz
picnixz deleted the feat/hashlib/sha3/heap-type-87138 branch December 8, 2024 17:53
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @srinivasreddy
pythongh-87138: convert SHA-3 object type to heap type (pythonGH-127670)
8e9a715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.