GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-124111: Fix TCL 9 threaded detection by cho-m · Pull Request #128103 · python/cpython

Conversation

cho-m commented Dec 19, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Original threaded detection doesn't work with TCL 9. Instead setting to always enable threaded based on release note for TCL 9+

https://sourceforge.net/projects/tcl/files/Tcl/9.0.0/tcl-release-notes-9.0.0.md/download:

No --disable-threads build option. Always thread-enabled.

Notes

I used gh-124111 as it was for general TCL 9 support (similarly piggy-backing off NEWS blurb as wasn't in stable release). Could create a separate issue/blurb if preferred.
I checked for TCL_MAJOR_VERSION as original logic was for looking for threaded in TCL. Could check TK_MAJOR_VERSION instead as the major versions should be the same.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-124111: Fix TCL 9 threaded detection

a2019e2

ghost commented Dec 19, 2024 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Dec 19, 2024

Copy link

Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot mentioned this pull request

Dec 19, 2024

Update tkinter to use Tk 8.6.15 or (better) Tk 9.0 #124111

Closed

bedevere-app Bot added the awaiting review label

Dec 19, 2024

cho-m mentioned this pull request

Dec 19, 2024

segmentation fault in [email protected] and [email protected] Homebrew/homebrew-core#199354

Closed

4 tasks done

Wulian233 approved these changes

Dec 20, 2024

View reviewed changes

bedevere-app Bot added awaiting core review and removed awaiting review labels

Dec 20, 2024

ZeroIntensity reviewed

Dec 25, 2024

View reviewed changes

ZeroIntensity left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a blurb, otherwise LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ZeroIntensity added topic-tkinter needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Dec 25, 2024

spyoungtech mentioned this pull request

Mar 12, 2025

Segmentation fault on MacOS 14.5 / Apple Silicon with Python 3.12.5 and FreeSimpleGUI 5.1.1 spyoungtech/FreeSimpleGUI#32

Open

tomasr8 removed the needs backport to 3.12 only security fixes label

Apr 10, 2025

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label

May 8, 2025

hugovk commented Oct 14, 2025

Copy link

Copy Markdown

Member

@cho-m Please can you add a news file?

See #128103 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chrstphrchvz mentioned this pull request

Nov 12, 2025

tkinter events not working since Python 3.14 w/ Tk 9.0 #141237

Closed

zware added 2 commits

November 12, 2025 15:43


          Add blurb

ee2bc67


          Merge remote-tracking branch 'origin/main' into tcl9-threaded-detection

771f2b9

zware enabled auto-merge (squash)

November 12, 2025 21:50

zware merged commit dc09870 into python:main

Nov 12, 2025

46 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Nov 12, 2025

Copy link

Copy Markdown

Thanks @cho-m for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Nov 12, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 12, 2025


          pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)

4ef8fd7

(cherry picked from commit dc09870)

Co-authored-by: Michael Cho <[email protected]>

bedevere-app Bot commented Nov 12, 2025

Copy link

Copy Markdown

GH-141482 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Nov 12, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 12, 2025


          pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)

7bd0cdc

(cherry picked from commit dc09870)

Co-authored-by: Michael Cho <[email protected]>

bedevere-app Bot commented Nov 12, 2025

Copy link

Copy Markdown

GH-141483 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Nov 12, 2025

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 13, 2025


          Merge branch 'main' into fix-issue21914

b9f473c

* main: (463 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 14, 2025


          Merge branch 'main' of github.com:python/cpython into fix-Issue18387

c46ecc5

* 'main' of github.com:python/cpython: (464 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 14, 2025


          Merge branch 'main' of github.com:python/cpython into fix-issue24255

c240289

* 'main' of github.com:python/cpython: (464 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request

Dec 6, 2025


          pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)

1a9c0f1

zaniebot mentioned this pull request

Oct 7, 2026

Fix Tcl 9 thread detection on Python 3.10–3.12 astral-sh/python-build-standalone#1321

Merged

zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request

Oct 7, 2026


          Fix Tcl 9 thread detection on Python 3.10–3.12 (#1321)

Python 3.10–3.12 treats Tcl 9 as non-threaded because Tcl 9 no longer
exposes `tcl_platform(threaded)`. This bypasses `_tkinter`'s
interpreter-thread dispatch, losing scheduled callbacks and potentially
crashing on calls from worker threads.

Backport python/cpython#128103 to these Unix builds so `_tkinter` treats
Tcl 9 as always threaded.

Fixes #1320.

---------

Co-authored-by: Zanie Blue <[email protected]>

Reviewers

ZeroIntensity

ZeroIntensity left review comments

+1 more reviewer

Wulian233

Wulian233 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cho-m commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Uh oh!

ghost commented Dec 19, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Dec 19, 2024

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

hugovk commented Oct 14, 2025

Uh oh!

Uh oh!

miss-islington-app Bot commented Nov 12, 2025

Uh oh!

bedevere-app Bot commented Nov 12, 2025

Uh oh!

bedevere-app Bot commented Nov 12, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cho-m commented Dec 19, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

ghost commented Dec 19, 2024 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.