GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-135801: Add the module parameter to compile() etc by serhiy-storchaka · Pull Request #139652 · python/cpython

Conversation

serhiy-storchaka commented Oct 6, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Many functions related to compiling or parsing Python code, such as compile(), ast.parse(), symtable.symtable(),
and importlib.abc.InspectLoader.source_to_code() now allow to pass the module name used when filtering syntax warnings.

Issue: Improve/fix filtering SyntaxWarnings by module #135801

📚 Documentation preview 📚: https://cpython-previews--139652.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added the DO-NOT-MERGE label

Oct 6, 2025

bedevere-app Bot mentioned this pull request

Oct 6, 2025

Improve/fix filtering SyntaxWarnings by module #135801

Closed

serhiy-storchaka mentioned this pull request

Oct 8, 2025

gh-131927: Do not emit PEP 765 warnings in ast.parse() #139642

Merged

serhiy-storchaka force-pushed the wip-compile-module branch from f6bd00b to d1592f2 Compare

October 14, 2025 16:31


          pythongh-135801: Add the module parameter to compile() etc

9a927b3

Many functions related to compiling or parsing Python code, such as
compile(), ast.parse(), symtable.symtable(),
and importlib.InspectLoader.source_to_code() now allow to pass
the module name used when filtering syntax warnings.

serhiy-storchaka force-pushed the wip-compile-module branch from d1592f2 to 9a927b3 Compare

October 16, 2025 17:22


          Merge branch 'main' into wip-compile-module

6a0b081

serhiy-storchaka removed the DO-NOT-MERGE label

Oct 30, 2025

serhiy-storchaka marked this pull request as ready for review

October 30, 2025 14:33

serhiy-storchaka requested review from AA-Turner, Eclips4, JelleZijlstra, brettcannon, carljm, ericsnowcurrently, iritkatriel, isidentical, lysnikolaou, markshannon, ncoghlan, pablogsal, tomasr8 and warsaw as code owners

October 30, 2025 14:33

bedevere-app Bot added the awaiting core review label

Oct 30, 2025

serhiy-storchaka added 5 commits

October 30, 2025 17:53


          Try to fix Sphinx warnings.

eb234eb


          Add more tests.


          Try to fix a Sphinx warning.

cb551e7


          Merge branch 'main' into wip-compile-module

92d4e5d


          Try to fix a Sphinx warning.

05a48bc

brettcannon removed their request for review

November 7, 2025 23:45

serhiy-storchaka commented Nov 8, 2025

Copy link

Copy Markdown

Member Author

@brettcannon, I am interested in your opinion as an import machinery expert. This PR changes importlib.abc.InspectLoader.source_to_code().

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner approved these changes

Nov 8, 2025

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The parameter might be named "module_name" or "modname", but I'm fine with "module".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Nov 8, 2025


          Merge branch 'main' into wip-compile-module

db56d94

serhiy-storchaka commented

Nov 9, 2025

View reviewed changes

Comment thread

Lib/test/test_cmd_line_script.py

		'-Werror:::test_pkg.__main__',
		os.path.join(zip_name, 'test_pkg')
		)
		self.assertEqual(err.count(b': SyntaxWarning: '), 12)

serhiy-storchaka Nov 9, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is a bug in zipimport that causes all warnings to be emitted twice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka mentioned this pull request

Nov 9, 2025

Syntax warnings are duplicated in zipimport #141276

Closed

serhiy-storchaka commented Nov 9, 2025

Copy link

Copy Markdown

Member Author

Thank you for your review @vstinner. I'll merge this PR next week if there are no other comments.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Nov 10, 2025

View reviewed changes

Comment thread

Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Nov 10, 2025

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core_and_Builtins/2025-10-06-14-19-47.gh-issue-135801.OhxEZS.rst

		@@ -0,0 +1,4 @@
		Many functions related to compiling or parsing Python code, such as

JelleZijlstra Nov 10, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix any bugs where modules imported through the import system produce incorrect SyntaxWarnings? If so, that should be mentioned separately.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka Nov 10, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already mentioned: "the module name used when filtering syntax warnings." Can you propose better wording?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra approved these changes

Nov 10, 2025

View reviewed changes

serhiy-storchaka and others added 2 commits

November 10, 2025 17:33


          Update Doc/whatsnew/3.15.rst

671df9b

Co-authored-by: Jelle Zijlstra <[email protected]>


          Improve documentation.

2d12469

serhiy-storchaka force-pushed the wip-compile-module branch from 642ffcb to 2d12469 Compare

November 12, 2025 10:36

serhiy-storchaka merged commit d8e6bdc into python:main

Nov 13, 2025

91 of 93 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Nov 13, 2025

serhiy-storchaka deleted the wip-compile-module branch

November 13, 2025 11:21

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 13, 2025


          Merge branch 'main' into fix-issue21914

b9f473c

* main: (463 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 14, 2025


          Merge branch 'main' of github.com:python/cpython into fix-Issue18387

c46ecc5

* 'main' of github.com:python/cpython: (464 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Nov 14, 2025


          Merge branch 'main' of github.com:python/cpython into fix-issue24255

c240289

* 'main' of github.com:python/cpython: (464 commits)
  pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603)
  pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974)
  pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310)
  pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521)
  pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884)
  pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668)
  pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378)
  pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009)
  pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496)
  pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128)
  pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499)
  pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652)
  pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909)
  pythongh-137109: refactor warning about threads when forking (python#141438)
  pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405)
  pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103)
  pythongh-141442: Add escaping to iOS testbed arguments (python#141443)
  pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969)
  Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167)
  pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428)
  ...

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request

Dec 6, 2025


          pythongh-135801: Add the module parameter to compile() etc (pythonGH-…

84bc85b

…139652)

Many functions related to compiling or parsing Python code, such as
compile(), ast.parse(), symtable.symtable(),
and importlib.abc.InspectLoader.source_to_code() now allow to pass
the module name used when filtering syntax warnings.

Reviewers

vstinner

vstinner approved these changes

JelleZijlstra

JelleZijlstra approved these changes

pablogsal

Awaiting requested review from pablogsal

pablogsal is a code owner

lysnikolaou

Awaiting requested review from lysnikolaou

lysnikolaou is a code owner

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

ncoghlan

Awaiting requested review from ncoghlan

ncoghlan is a code owner

warsaw

Awaiting requested review from warsaw

warsaw is a code owner

carljm

Awaiting requested review from carljm

carljm is a code owner

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

iritkatriel

Awaiting requested review from iritkatriel

iritkatriel is a code owner

isidentical

Awaiting requested review from isidentical

isidentical is a code owner

Eclips4

Awaiting requested review from Eclips4

Eclips4 is a code owner

tomasr8

Awaiting requested review from tomasr8

tomasr8 is a code owner

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Nov 8, 2025

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Nov 9, 2025

Uh oh!

Uh oh!

JelleZijlstra Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serhiy-storchaka commented Oct 6, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.