GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Split _testcapimodule.c into smaller files by vstinner · Pull Request #129400 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

  • Move many functions from _testcapimodule.c into more specific files in Modules/_testcapi/.

  • Add files:

    • Modules/_testcapi/frame.c
    • Modules/_testcapi/function.c
    • Modules/_testcapi/type.c

  • In moved code:

    • Replace get_testerror() with PyExc_AssertionError.
    • Replace raiseTestError() with PyErr_Format(PyExc_AssertionError, ...).
  • Issue: Split up _testcapimodule.c #93649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Jan 28, 2025
@vstinner
vstinner requested review from a team, erlend-aasland and markshannon as code owners January 28, 2025 13:10
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 28, 2025
Split up _testcapimodule.c #93649
Open
@vstinner
vstinner requested a review from ericsnowcurrently as a code owner January 29, 2025 11:02
@vstinner
pythongh-93649: Split _testcapimodule.c into smaller files
78d4204 
* Move many functions from _testcapimodule.c into more specific files
  in Modules/_testcapi/.

* Add files:

  * Modules/_testcapi/frame.c
  * Modules/_testcapi/function.c
  * Modules/_testcapi/type.c

* In moved code:

  * Replace get_testerror() with PyExc_AssertionError.
  * Replace raiseTestError() with
    PyErr_Format(PyExc_AssertionError, ...).
@vstinner
vstinner force-pushed the split_testcapi branch from bd6adbe to 78d4204 Compare January 31, 2025 09:23
@vstinner
vstinner marked this pull request as draft January 31, 2025 13:11
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 31, 2025
@vstinner

vstinner commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

I have split this PR into smaller PRs:

  • gh-93649: Move PyFrame C API tests to test_capi #129512
  • gh-93649: Add Modules/_testcapi/type.c file #129516
  • gh-93649: Add Modules/_testcapi/function.c file #129521
  • gh-93649: Move _testcapi tests to specific files #129544
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Feb 1, 2025
@vstinner
vstinner deleted the split_testcapi branch February 1, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.