GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Move PyFrame C API tests to test_capi by vstinner · Pull Request #129512 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 31, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Move C API tests from test_frame to test_capi.test_frame.
  • Add Modules/_testcapi/frame.c file.
  • Add Lib/test/test_capi/test_frame.py file.
  • Issue: Split up _testcapimodule.c #93649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-93649: Move PyFrame C API tests to test_capi
b305bcd 
* Move C API tests from test_frame to test_capi.test_frame.
* Add Modules/_testcapi/frame.c file.
* Add Lib/test/test_capi/test_frame.py file.
@vstinner vstinner added the skip news label Jan 31, 2025
@vstinner
vstinner requested review from a team and erlend-aasland as code owners January 31, 2025 12:00
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 31, 2025
Split up _testcapimodule.c #93649
Open
@vstinner
vstinner merged commit 8b70ff5 into python:main Jan 31, 2025
@vstinner
vstinner deleted the testcapi_frame branch January 31, 2025 12:52
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 31, 2025
@vstinner vstinner mentioned this pull request Feb 1, 2025
gh-93649: Split _testcapimodule.c into smaller files #129400
Closed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@vstinner @srinivasreddy
pythongh-93649: Move PyFrame C API tests to test_capi (python#129512)
15a6d3a 
* Add Lib/test/test_capi/test_frame.py file.
* Move C API tests from test_frame to test_capi.test_frame.
* Add Modules/_testcapi/frame.c file.
* Move C API tests from _testcapimodule.c to frame.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.