GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Move _testcapi tests to specific files by vstinner · Pull Request #129544 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 1, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move many functions from _testcapimodule.c into more specific files in Modules/_testcapi/.

In moved code:

  • Replace get_testerror() with PyExc_AssertionError.
  • Replace raiseTestError() with PyErr_Format(PyExc_AssertionError, ...).
  • Issue: Split up _testcapimodule.c #93649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-93649: Move _testcapi tests to specific files
3593b77 
Move many functions from _testcapimodule.c into more specific files
in Modules/_testcapi/.

In moved code:

* Replace get_testerror() with PyExc_AssertionError.
* Replace raiseTestError() with
  PyErr_Format(PyExc_AssertionError, ...).
@vstinner
vstinner requested a review from markshannon as a code owner February 1, 2025 11:33
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 1, 2025
Split up _testcapimodule.c #93649
Open
@vstinner vstinner added the skip news label Feb 1, 2025
@vstinner
Fix test_string_to_double()
2442857
@vstinner
vstinner merged commit 71ae933 into python:main Feb 1, 2025
@vstinner
vstinner deleted the testcapi_split2 branch February 1, 2025 12:39
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 1, 2025
@vstinner vstinner mentioned this pull request Feb 1, 2025
gh-93649: Split _testcapimodule.c into smaller files #129400
Closed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@vstinner @srinivasreddy
pythongh-93649: Move _testcapi tests to specific files (python#129544)
9dd7e45 
Move many functions from _testcapimodule.c into more specific files
in Modules/_testcapi/.

In moved code:

* Replace get_testerror() with PyExc_AssertionError.
* Replace raiseTestError() with
  PyErr_Format(PyExc_AssertionError, ...).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.