GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125174: Make immortality "sticky" by markshannon · Pull Request #131184 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Make immortality "sticky" by increasing the threshold for immortality in increfs, but leaving it the same for decrefs.

This way, no object will ever see more decrefs than increfs. Immortal objects may see more increfs than decrefs, but that's not a problem.

Performance is neutral.

  • Issue: "Immortal" objects aren't immortal and that breaks things. #125174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 2 commits March 12, 2025 15:51
@markshannon
Add some tolerance to no-gil immortality
b1e2a33
@markshannon
Add test
2a08194
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2025
"Immortal" objects aren't immortal and that breaks things. #125174
Closed
@markshannon markshannon added the skip news label Mar 13, 2025
@markshannon
Exit test early if not enough memory
9a1bee5
iritkatriel
iritkatriel approved these changes Mar 13, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 13, 2025
@markshannon
markshannon merged commit 3a91ee9 into python:main Mar 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 13, 2025
@encukou

encukou commented Mar 14, 2025

Copy link
Copy Markdown
Member

This broke refleak buildbots.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon added a commit to faster-cpython/cpython that referenced this pull request Mar 14, 2025
@markshannon
Revert "pythonGH-125174: Make immortality "sticky" (pythonGH-131184)"
d91d1cd 
This reverts commit 3a91ee9.
hugovk pushed a commit that referenced this pull request Mar 14, 2025
@markshannon
GH-125174 Revert: Make immortality "sticky" (GH-131184)" (#131230)
2250ab6 
Revert "GH-125174: Make immortality "sticky" (GH-131184)"

This reverts commit 3a91ee9.
@markshannon markshannon mentioned this pull request Mar 17, 2025
GH-125174: Make immortality "sticky" #131355
Merged
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@markshannon @plashchynski
pythonGH-125174: Make immortality "sticky" (pythonGH-131184)
10493a0
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@markshannon @plashchynski
pythonGH-125174 Revert: Make immortality "sticky" (pythonGH-131184)" (p…
0c7611e 
…ython#131230)

Revert "pythonGH-125174: Make immortality "sticky" (pythonGH-131184)"

This reverts commit 3a91ee9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @encukou @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.