GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125174 Revert: Make immortality "sticky" (GH-131184)" by markshannon · Pull Request #131230 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 3a91ee9.

  • Issue: "Immortal" objects aren't immortal and that breaks things. #125174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Revert "pythonGH-125174: Make immortality "sticky" (pythonGH-131184)"
d91d1cd 
This reverts commit 3a91ee9.
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2025
"Immortal" objects aren't immortal and that breaks things. #125174
Closed
@markshannon markshannon added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 14, 2025
@bedevere-bot

bedevere-bot commented Mar 14, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit d91d1cd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131230%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 14, 2025
hugovk
hugovk approved these changes Mar 14, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 14, 2025
@hugovk
hugovk merged commit 2250ab6 into python:main Mar 14, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 14, 2025
@hugovk

hugovk commented Mar 14, 2025

Copy link
Copy Markdown
Member

Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon deleted the revert-131184 branch March 17, 2025 11:27
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@markshannon @plashchynski
pythonGH-125174 Revert: Make immortality "sticky" (pythonGH-131184)" (p…
0c7611e 
…ython#131230)

Revert "pythonGH-125174: Make immortality "sticky" (pythonGH-131184)"

This reverts commit 3a91ee9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.